Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Sep 1998 21:35:33 +0200
From:      Eivind Eklund <eivind@yes.no>
To:        Warner Losh <imp@village.org>
Cc:        "Kenneth D. Merry" <ken@plutotech.com>, scsi@FreeBSD.ORG
Subject:   Re: Fixing LINT
Message-ID:  <19980918213533.18854@follo.net>
In-Reply-To: <199809181925.NAA28114@harmony.village.org>; from Warner Losh on Fri, Sep 18, 1998 at 01:25:54PM -0600
References:  <19980918194533.52865@follo.net> <19980918184204.00622@follo.net> <199809181707.LAA10835@panzer.plutotech.com> <19980918194533.52865@follo.net> <199809181925.NAA28114@harmony.village.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 18, 1998 at 01:25:54PM -0600, Warner Losh wrote:
> In message <19980918194533.52865@follo.net> Eivind Eklund writes:
> : It doesn't link, either.  Same reason.
> 
> What are you talking about?  It links and works fine for me.  I've
> been using it to access my cdrom changer for a few weeks.  The file
> that is commented out in sys/i386/conf/files.i386 is the OLD aha
> driver.  The new one is in both the sys/conf/files and
> sys/i386/conf/files.i386 files.  What is missing for you?

That LINT compiles and link, as it is supposed to do at all times.  At
least bde and I use it as a tool for doing global kernel checks; more
people should (after any large-scale change, LINT should compile with
no new warnings).

However, after looking some more at this, I found (about 1 minute
before I got your mail :-) that the problem for aha is that the wrong
aha line is in LINT, and for adv that it has non-compilable code inside
#ifdef DIAGNOSTIC.

I've copied the correct aha line over, and commented out adv from LINT
for the time being.  New diffs are:

Index: LINT
===================================================================
RCS file: /home/ncvs/src/sys/i386/conf/LINT,v
retrieving revision 1.470
diff -u -r1.470 LINT
--- LINT	1998/09/18 00:46:41	1.470
+++ LINT	1998/09/18 19:28:12
@@ -879,19 +879,20 @@
 #
 
 controller	bt0	at isa? port "IO_BT0" cam irq ?
-controller	adv0	at isa? port ? cam irq ?
-controller	aha0	at isa? port "IO_AHA0" bio irq ? drq 5 vector ahaintr
-controller	uha0	at isa? port "IO_UHA0" bio irq ? drq 5 vector uhaintr
-
-controller      aic0    at isa? port 0x340 bio irq 11 vector aicintr
-controller	nca0	at isa? port 0x1f88 bio irq 10 vector ncaintr
-controller	nca1	at isa? port 0x1f84
-controller	nca2	at isa? port 0x1f8c
-controller	nca3	at isa? port 0x1e88
-controller	nca4	at isa? port 0x350 bio irq 5 vector ncaintr
+# adv is broken when DIAGNOSTIC is defined
+#controller	adv0	at isa? port ? cam irq ?
+controller      aha0    at isa? port ? cam irq ?
+#!CAM# controller	uha0	at isa? port "IO_UHA0" bio irq ? drq 5 vector uhaintr
+
+#!CAM# controller      aic0    at isa? port 0x340 bio irq 11 vector aicintr
+#!CAM# controller	nca0	at isa? port 0x1f88 bio irq 10 vector ncaintr
+#!CAM# controller	nca1	at isa? port 0x1f84
+#!CAM# controller	nca2	at isa? port 0x1f8c
+#!CAM# controller	nca3	at isa? port 0x1e88
+#!CAM# controller	nca4	at isa? port 0x350 bio irq 5 vector ncaintr
 
-controller	sea0	at isa? bio irq 5 iomem 0xdc000 iosiz 0x2000 vector seaintr
-controller	wds0	at isa? port 0x350 bio irq 15 drq 6 vector wdsintr
+#!CAM# controller	sea0	at isa? bio irq 5 iomem 0xdc000 iosiz 0x2000 vector seaintr
+#!CAM# controller	wds0	at isa? port 0x350 bio irq 15 drq 6 vector wdsintr
 
 #
 # ST-506, ESDI, and IDE hard disks: `wdc' and `wd'
@@ -1462,7 +1463,7 @@
 controller	ahc1
 controller	ncr0
 controller	isp0
-controller	amd0
+#!CAM# controller	amd0
 device		de0
 device		fxp0
 device		tl0
@@ -1558,7 +1559,7 @@
 # ppc	ISA-bus parallel port interfaces.  
 #
 controller	ppbus0
-controller	vpo0	at ppbus?
+#!CAM# controller	vpo0	at ppbus?
 device		nlpt0	at ppbus?
 device		plip0	at ppbus?
 device		ppi0	at ppbus?
@@ -1709,9 +1710,9 @@
 # DPT options
 options DPT_VERIFY_HINTR
 options DPT_RESTRICTED_FREELIST
-options DPT_MEASURE_PERFORMANCE
+#!CAM# options DPT_MEASURE_PERFORMANCE
 options DPT_FREELIST_IS_STACK
-options DPT_HANDLE_TIMEOUTS
+#!CAM# options DPT_HANDLE_TIMEOUTS
 options DPT_TIMEOUT_FACTOR=4
 options	DPT_INTR_DELAY=200      # Some motherboards need that
 options DPT_LOST_IRQ

Any protests this time around?  (I can't easily fix the adv driver, as
it is mumbling about missing symbols that I have no idea where have
come from or gone to).

Eivind.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980918213533.18854>