From owner-dev-commits-src-main@freebsd.org Thu Jan 28 17:42:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2854D4E4C88 for ; Thu, 28 Jan 2021 17:42:34 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DRSV20CrTz4R4Z for ; Thu, 28 Jan 2021 17:42:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f41.google.com with SMTP id a1so6295268wrq.6 for ; Thu, 28 Jan 2021 09:42:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ntyw12YzgyfdRixlPgtmryqiCV/2WVCuKGhPZlyCy9E=; b=F/TvMhpaGXCn5nwq9hBgN9PYCP7KxAc7twhb5fjLoRv7vWH48YPpAGHaAuI83yYOWB AEE3Nb+XkgXFw39qhJUx9LvZbzV0G/4/TECvULAl9pgciSie8/Cdnu6HBvW+gjTbf0TN YqMi3juKpGadoRPgODazkHkZB9WIC1SPNN9T/W/V3iVGa/3yILuNYL19nrdi3bkC3dMo ZINI4A1+PU6kGyvZerZRcux0fMeu8dsRpXogadpO9dXqXKDE34Yi6W2Hr/i1w+fbsauk pLPRuakubSKABxm4eGwBb9/iK1XYnt3a5PPJ5bpBcM2JW/5Ub/j2T1/kMs/cB6Ug0VP/ d7LQ== X-Gm-Message-State: AOAM533ZohQEFebqH88VlZg49ZBAI1T2pBlBGKjdcqkyu62vMcr0oqIx /nL/jKtJk9dyFHydqWiaPcQv60ZYIsf/P6R5r1Y= X-Google-Smtp-Source: ABdhPJw7nD9YHrEIBliOnAMH/kn558k7SWnL4dMBH48EejaziRsg4HQtUbOsQLjK2mkMxm2zJk6OzA== X-Received: by 2002:a5d:62c1:: with SMTP id o1mr158120wrv.275.1611855752524; Thu, 28 Jan 2021 09:42:32 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id x1sm6973247wmi.14.2021.01.28.09.42.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jan 2021 09:42:31 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 83ff5d5d98cb - main - Un-XFAIL two tests with Clang > 10 From: Jessica Clarke In-Reply-To: <202101281739.10SHdh37056796@gitrepo.freebsd.org> Date: Thu, 28 Jan 2021 17:42:30 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6B60F7D5-AD3E-459E-801A-65234A689A01@freebsd.org> References: <202101281739.10SHdh37056796@gitrepo.freebsd.org> To: Alex Richardson X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DRSV20CrTz4R4Z X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 17:42:34 -0000 Is the commit message or the diff wrong? Both use strict inequalities. Jess On 28 Jan 2021, at 17:39, Alex Richardson = wrote: >=20 > The branch main has been updated by arichardson: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D83ff5d5d98cbcf9b66dccd70022358ae= c8918a14 >=20 > commit 83ff5d5d98cbcf9b66dccd70022358aec8918a14 > Author: Alex Richardson > AuthorDate: 2021-01-28 17:17:49 +0000 > Commit: Alex Richardson > CommitDate: 2021-01-28 17:24:24 +0000 >=20 > Un-XFAIL two tests with Clang > 10 >=20 > SVN r343917 fixed this for in-tree clang, but when building with a = newer > out-of-tree clang the test was still marked as XFAIL. >=20 > Reviewed By: dim > Differential Revision: https://reviews.freebsd.org/D28390 > --- > contrib/netbsd-tests/lib/libm/t_cbrt.c | 4 ++-- > lib/msun/tests/trig_test.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/contrib/netbsd-tests/lib/libm/t_cbrt.c = b/contrib/netbsd-tests/lib/libm/t_cbrt.c > index d2cdd47a5beb..08e9faeb145c 100644 > --- a/contrib/netbsd-tests/lib/libm/t_cbrt.c > +++ b/contrib/netbsd-tests/lib/libm/t_cbrt.c > @@ -269,8 +269,8 @@ ATF_TC_BODY(cbrtl_powl, tc) > size_t i; >=20 > #if defined(__amd64__) && defined(__clang__) && __clang_major__ >=3D 7 = && \ > - __FreeBSD_cc_version < 1300002 > - atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); > + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 > + atf_tc_expect_fail("test fails with clang 7-9 - bug 234040"); > #endif >=20 > for (i =3D 0; i < __arraycount(x); i++) { > diff --git a/lib/msun/tests/trig_test.c b/lib/msun/tests/trig_test.c > index 483a5e187d50..ba1975721d3f 100644 > --- a/lib/msun/tests/trig_test.c > +++ b/lib/msun/tests/trig_test.c > @@ -161,7 +161,7 @@ ATF_TC_BODY(reduction, tc) > unsigned i; >=20 > #if defined(__amd64__) && defined(__clang__) && __clang_major__ >=3D 7 = && \ > - __FreeBSD_cc_version < 1300002 > + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 > atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); > #endif >=20