From owner-freebsd-bugs@FreeBSD.ORG Tue Jan 19 09:20:08 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03B01106568F for ; Tue, 19 Jan 2010 09:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 07AAA8FC21 for ; Tue, 19 Jan 2010 09:20:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0J9K5Ie034643 for ; Tue, 19 Jan 2010 09:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0J9K5HJ034642; Tue, 19 Jan 2010 09:20:05 GMT (envelope-from gnats) Resent-Date: Tue, 19 Jan 2010 09:20:05 GMT Resent-Message-Id: <201001190920.o0J9K5HJ034642@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "G. Paul Ziemba" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84C0F1065693 for ; Tue, 19 Jan 2010 09:11:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 73A588FC1F for ; Tue, 19 Jan 2010 09:11:51 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0J9BpGr037351 for ; Tue, 19 Jan 2010 09:11:51 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o0J9Bpre037350; Tue, 19 Jan 2010 09:11:51 GMT (envelope-from nobody) Message-Id: <201001190911.o0J9Bpre037350@www.freebsd.org> Date: Tue, 19 Jan 2010 09:11:51 GMT From: "G. Paul Ziemba" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/142960: [patch] sysinstall comparison of cdrom.inf CD_VERSION against "any" is broken X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2010 09:20:08 -0000 >Number: 142960 >Category: bin >Synopsis: [patch] sysinstall comparison of cdrom.inf CD_VERSION against "any" is broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jan 19 09:20:05 UTC 2010 >Closed-Date: >Last-Modified: >Originator: G. Paul Ziemba >Release: 8.0 >Organization: >Environment: FreeBSD gw2.ziemba.us 8.0-STABLE FreeBSD 8.0-STABLE #3: Sat Jan 9 08:56:12 PST 2010 root@gw2.ziemba.us:/usr/obj/usr/src/sys/GENERIC i386 >Description: setting CDROM_VERSION=any in cdrom.inf should silence sysinstall's complaints about mismatched versions, yet it doesn't. The problem is an incorrect use of variable_cmp() where strcmp should be: --- cdrom.c.orig 2009-08-03 01:13:06.000000000 -0700 +++ cdrom.c 2010-01-19 01:05:33.000000000 -0800 @@ -142,7 +142,7 @@ else { if (variable_cmp(VAR_RELNAME, cp) && variable_cmp(VAR_RELNAME, "any") && - variable_cmp(cp, "any") && + strcmp(cp, "any") && !bogusCDOK) { msgConfirm("Warning: The version of the FreeBSD disc currently in the drive\n" "(%s) does not match the version of the boot floppy\n" >How-To-Repeat: Make cdrom with install.cfg and cdrom.inf. Contents of cdrom.inf are: CD_VERSION=any CD_MACHINE_ARCH=any Run sysinstall and attempt to load configuration file from CD. Sysinstall complains about version mismatch. >Fix: Change variable_cmp to strcmp in the line indicated in problem description. >Release-Note: >Audit-Trail: >Unformatted: