From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 12 00:43:26 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 593CEE89 for ; Tue, 12 Mar 2013 00:43:26 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by mx1.freebsd.org (Postfix) with ESMTP id 1175ECFD for ; Tue, 12 Mar 2013 00:43:25 +0000 (UTC) Received: by mail-pb0-f46.google.com with SMTP id uo15so4370209pbc.19 for ; Mon, 11 Mar 2013 17:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=i/s/4js8uJGKmeQto/zpb9Hma2DRvNy/lB/0aUD/Nw8=; b=lqJ9zbVaJS+bdLKsZqagxToXo8o1Ghf7JJglwvbZiQ0iVd4X4DEmzGy5uHl7qy7p5I IhGgzyY7fXcTY9XsuBMNWdo65nBdCHS+YJEfICgrAtH6Ic9KWLaq2kMh+Ah9hSssJgqx h2L0rrlBUiw8Lp+akMLV23EcfZiLyG2GIkBlokzo+UsGhrLgpwqcouq0dSj6DjcW0Iv0 4yelfGDDg9zIlTaTxv4SiFSTVQ9tAuKouCoHXz9Dz36+D/NrLvMvgwTslUGBhKHEDOTP DW+2R+r2/t4gu0F/Yc9OWmn2sSK0oAN0jjyPd/BrNmCPaxru8+8hzZzYi+NFhsxMLP5w fLgg== MIME-Version: 1.0 X-Received: by 10.68.211.37 with SMTP id mz5mr26612576pbc.83.1363049004509; Mon, 11 Mar 2013 17:43:24 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.70.39.69 with HTTP; Mon, 11 Mar 2013 17:43:24 -0700 (PDT) In-Reply-To: References: <513d3ae3.08c2440a.59a6.63b2@mx.google.com> <513DA767.6010208@gmail.com> <513E6AF5.9010304@gmail.com> <513E7924.3060302@gmail.com> Date: Mon, 11 Mar 2013 17:43:24 -0700 X-Google-Sender-Auth: ghObHtAV28Esc_3QYz4WJKLlUEA Message-ID: Subject: Re: Fine, OK, here's my initial AR9380/AR9485 support From: Adrian Chadd To: Joshua Isom Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 00:43:26 -0000 .. and yeah, that code is wrong. GCC doesn't complain; just change it to: if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) && to: if ((ahp->ah_enterprise_mode & AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) && Thanks, this is the first bug that I can file as having come from the FreeBSD community. :) Adrian On 11 March 2013 17:41, Adrian Chadd wrote: > Is this with clang? > > > > > adrian > > > On 11 March 2013 17:39, Joshua Isom wrote: >> Still no luck, and some errors look like I'm missing more. >> >> >> /root/ATH/head/sys/modules/ath/../../dev/ath/ath_hal/ar9003/ar9300_misc.c:853:38: >> error: use of logical '&&' with constant operand >> [-Werror,-Wconstant-logical-operand] >> if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) && >> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> AR_ENT_OTP_MIN_PKT_SIZE_DISABLE is defined in ar9300reg.h and hardcoded. >> >> At least you figured out an easy way to genuine check to see if someone >> tried your code. >> >> >> On 3/11/2013 6:41 PM, Adrian Chadd wrote: >>> >>> Ooh.. add the debug options to your kernel, sorry! >>> >>> options ATH_DEBUG >>> options AH_DEBUG >>> options ATH_DIAGAPI >>> >>> I'm sorry, I've never tested it outside of a debug build before. >>> >>> >>> >>> >>> Adrian >>> >>