From owner-svn-src-all@FreeBSD.ORG  Wed Dec 21 20:41:06 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 99B36106564A;
	Wed, 21 Dec 2011 20:41:06 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 817E38FC17;
	Wed, 21 Dec 2011 20:41:04 +0000 (UTC)
Received: by lahl5 with SMTP id l5so4397796lah.13
	for <multiple recipients>; Wed, 21 Dec 2011 12:41:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=eitanadler.com; s=0xdeadbeef;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type
	:content-transfer-encoding;
	bh=k8/ByALdWoimyjg1pACvBMu0pf93TJJh7jYd3E2gOGA=;
	b=n3xXcKYvb3FMjJxPrrndFfccXA0J7/d7V16ITuG1C3c/lE/MKUZVId8XWW1lgeKg5I
	oaJd7lWI+MdyQ8M7V9++zHvtYHOoo2IGxbxKFQG4/ATt8dPwxds4XQcFVGb/xpwgYVj1
	anMkz6Ju9MA0Xl0w2upGi54V5K/Lg2gCeWgBc=
Received: by 10.152.103.51 with SMTP id ft19mr6993430lab.42.1324500064125;
	Wed, 21 Dec 2011 12:41:04 -0800 (PST)
MIME-Version: 1.0
Sender: lists@eitanadler.com
Received: by 10.152.129.8 with HTTP; Wed, 21 Dec 2011 12:40:33 -0800 (PST)
In-Reply-To: <4EF243F2.7030000@FreeBSD.org>
References: <201112212027.pBLKRfPK084637@svn.freebsd.org>
	<4EF243F2.7030000@FreeBSD.org>
From: Eitan Adler <eadler@freebsd.org>
Date: Wed, 21 Dec 2011 15:40:33 -0500
X-Google-Sender-Auth: 6enZDyhREk8_pNqJnwwQRq2L2yQ
Message-ID: <CAF6rxgku88PABx9J8UxfLkKm+Y-3b6+DB+X6cjUce-LfX7VESg@mail.gmail.com>
To: Doug Barton <dougb@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog
	ypserv
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2011 20:41:06 -0000

On Wed, Dec 21, 2011 at 3:39 PM, Doug Barton <dougb@freebsd.org> wrote:
> A better way to write this commit log would be, "Remove null pointer
> checks that are extraneous because ..." =C2=A02/3 why, 1/3 what.

Noted.

>> =C2=A0 - Fix memory leak
>
> Should this perhaps have been a separate commit?

Probably. I'll be more careful next time.


--=20
Eitan Adler
Ports committer
X11, Bugbusting teams