From owner-svn-src-all@FreeBSD.ORG  Wed Jun  5 08:13:08 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id EF206F73;
 Wed,  5 Jun 2013 08:13:08 +0000 (UTC) (envelope-from das@freebsd.org)
Received: from zim.MIT.EDU (50-196-151-174-static.hfc.comcastbusiness.net
 [50.196.151.174])
 by mx1.freebsd.org (Postfix) with ESMTP id D401C1ADE;
 Wed,  5 Jun 2013 08:13:08 +0000 (UTC)
Received: from zim.MIT.EDU (localhost [127.0.0.1])
 by zim.MIT.EDU (8.14.7/8.14.2) with ESMTP id r558D1Fv043027;
 Wed, 5 Jun 2013 01:13:02 -0700 (PDT) (envelope-from das@freebsd.org)
Received: (from das@localhost)
 by zim.MIT.EDU (8.14.7/8.14.2/Submit) id r558D1UI043026;
 Wed, 5 Jun 2013 01:13:01 -0700 (PDT) (envelope-from das@freebsd.org)
Date: Wed, 5 Jun 2013 01:13:01 -0700
From: David Schultz <das@freebsd.org>
To: Chris Rees <utisoft@gmail.com>
Subject: Re: svn commit: r251404 - in head/lib/msun: . src
Message-ID: <20130605081301.GA42959@zim.MIT.EDU>
References: <201306050533.r555X2dQ047208@svn.freebsd.org>
 <CADLo83-8Q-uSD3JxiiGG4ZEfrYuR5sGc4+MaFNr4Q00B=TWd-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADLo83-8Q-uSD3JxiiGG4ZEfrYuR5sGc4+MaFNr4Q00B=TWd-w@mail.gmail.com>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2013 08:13:09 -0000

On Wed, Jun 05, 2013, Chris Rees wrote:
> On 5 Jun 2013 06:33, "David Schultz" <das@freebsd.org> wrote:
> >
> > Author: das
> > Date: Wed Jun  5 05:33:01 2013
> > New Revision: 251404
> > URL: http://svnweb.freebsd.org/changeset/base/251404
> >
> > Log:
> >   Style fixes.
> >
> >   Submitted by: bde
> >
> > Modified:
> >   head/lib/msun/Makefile
> >   head/lib/msun/src/catrig.c
> >   head/lib/msun/src/catrigf.c
> >   head/lib/msun/src/e_log2.c
> >
> > Modified: head/lib/msun/Makefile
> >
> ==============================================================================
> > --- head/lib/msun/Makefile      Wed Jun  5 01:22:59 2013        (r251403)
> > +++ head/lib/msun/Makefile      Wed Jun  5 05:33:01 2013        (r251404)
> > @@ -21,6 +21,10 @@ ARCH_SUBDIR= ${MACHINE_CPUARCH}
> >  .include "${ARCH_SUBDIR}/Makefile.inc"
> >
> >  .PATH: ${.CURDIR}/${ARCH_SUBDIR}
> > +.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64"
> > +.PATH: ${.CURDIR}/x86
> > +CFLAGS+=       -I${.CURDIR}/x86
> > +.endif
> 
> Since you're doing style fixes, it is worth noting that quoting strings in
> Makefiles is nearly always incorrect, and only works in our make because of
> an extension.

Thanks -- I didn't know that, and apparently neither did whoever
wrote that line originally.  But quoted strings are pervasive in
our makefiles; if there's a good reason to fix it, perhaps you
could go through and clean them up. :)