From owner-p4-projects@FreeBSD.ORG  Tue Jun 16 12:45:21 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 38CBB1065675; Tue, 16 Jun 2009 12:45:21 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ED6471065673
	for <perforce@FreeBSD.org>; Tue, 16 Jun 2009 12:45:20 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id DB4388FC1A
	for <perforce@FreeBSD.org>; Tue, 16 Jun 2009 12:45:20 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5GCjKAh045201
	for <perforce@FreeBSD.org>; Tue, 16 Jun 2009 12:45:20 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5GCjKK6045199
	for perforce@freebsd.org; Tue, 16 Jun 2009 12:45:20 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Date: Tue, 16 Jun 2009 12:45:20 GMT
Message-Id: <200906161245.n5GCjKK6045199@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zhaoshuai@FreeBSD.org using -f
From: Zhao Shuai <zhaoshuai@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 164496 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2009 12:45:22 -0000

http://perforce.freebsd.org/chv.cgi?CH=164496

Change 164496 by zhaoshuai@zhaoshuai on 2009/06/16 12:44:34

	select/poll() hang up is the right behavior.

Affected files ...

.. //depot/projects/soc2009/fifo/fifo_test/functionality/poll.c#3 edit
.. //depot/projects/soc2009/fifo/fifo_test/functionality/select.c#6 edit

Differences ...

==== //depot/projects/soc2009/fifo/fifo_test/functionality/poll.c#3 (text+ko) ====

@@ -1,7 +1,7 @@
 /*
  * Basic FIFO poll test.
  *
- * 1. poll on read descriptor - The same problem as select.
+ * 1. poll on read descriptor - OK.
  * 2. poll on write descriptor - OK.
  */
 
@@ -41,6 +41,11 @@
 		ret = poll(&pfd, 1, INFTIM);
 		if (ret > 0) {
 			printf("poll returned %d, revents = %d\n", ret, (int)pfd.revents);
+
+			if (pfd.revents & POLLHUP) {
+				printf("peer disconnected\n");
+				return (0);
+			}
 #if TEST_READ
 			if (pfd.revents & POLLRDNORM) {
 				n = read(fd, rbuf, BUF_SIZE);

==== //depot/projects/soc2009/fifo/fifo_test/functionality/select.c#6 (text+ko) ====

@@ -1,10 +1,7 @@
 /*
  * Basic FIFO select test.
  *
- * 1. select on read descriptor - XXX
- *	if writer exits before us, "top" shows that we are busy
- *	consuming CPU rather than sleep.
- *
+ * 1. select on read descriptor - OK
  * 2. select on write descriptor - OK
  */