From owner-svn-ports-all@FreeBSD.ORG Wed Jan 9 07:29:27 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 84776730; Wed, 9 Jan 2013 07:29:27 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-qa0-f51.google.com (mail-qa0-f51.google.com [209.85.216.51]) by mx1.freebsd.org (Postfix) with ESMTP id BFEAF779; Wed, 9 Jan 2013 07:29:26 +0000 (UTC) Received: by mail-qa0-f51.google.com with SMTP id i20so458586qad.10 for ; Tue, 08 Jan 2013 23:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=d8rl4YpgeDlFnnNk6LTcPg30ikRRFLPr2QTvcYxkRZk=; b=WQlAJOZ8+T9lH8tSlFdGDNBHRKc5n3EzafNTacQ5WFl2KnkqRQpH5gQPG8nqIUd1mf HCi4WJkcXWIOgoontmS+WWeYZB/fVYXoNsWscOPDVDrHWe2T9AZhHp1S4oNT7IYb5AjV R4zQj8jWMvYWSHMC8zRW9BiaGpD7sZjynl9d+FEDMAAQJdXqTFegAzsWJYHvZDIkV0CS r72yoVaN1iJlG9hjGfUyyW7oKGjPVNUI0VuPclFWefbJJl1OkCBQEyVv1yNqqwLR2KGn q9L87JU6ZWnD+fDSpHf0s1QSFkkoHAP0gcy3Gn6gcreLa6nogrde8m47/sd8I8LS+7zn pnKA== X-Received: by 10.229.197.197 with SMTP id el5mr12353585qcb.140.1357716565976; Tue, 08 Jan 2013 23:29:25 -0800 (PST) Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68]) by mx.google.com with ESMTPS id gg3sm18778501qeb.5.2013.01.08.23.29.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Jan 2013 23:29:25 -0800 (PST) Sender: "Jason E. Hale" From: "Jason E. Hale" To: Baptiste Daroussin Subject: Re: svn commit: r310110 - in head: . mail/perdition mail/perdition/files Date: Wed, 09 Jan 2013 02:29:23 -0500 Message-ID: <1684549.OSdhx2gJ5Y@mocha.verizon.net> User-Agent: KMail/4.8.4 (FreeBSD/9.0-RELEASE-p3; KDE/4.8.4; i386; ; ) In-Reply-To: <20130109000747.GH85686@ithaqua.etoilebsd.net> References: <201301082233.r08MXBtn030900@svn.freebsd.org> <20130109000747.GH85686@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2013 07:29:27 -0000 On Wednesday, January 09, 2013 01:07:48 Baptiste Daroussin wrote: > On Tue, Jan 08, 2013 at 10:33:11PM +0000, Jason E. Hale wrote: > > +OPTIONS_DEFINE= BDB DAEMON_MAP GDBM MYSQL NIS ODBC OPENLDAP OPENSSL > > PGSQL POSIX_REGEX SSL > The last SSL is unused in the rest of the port, it can probably be removed. > Thanks, I missed that. > Why not appending DOCS given that the dialog will be shown anyway? While I > do understand that people do not create an OPTIONS_DEFINE just for DOCS do > avoid prompting the dialog all the time, I do think that if there is > already an OPTIONS_DEFINE then it is worth appending DOCS to it. > > > +OPTIONS_DEFAULT= GDBM POSIX_REGEX SSL > > I agree, I'll add it. > > -.if !defined(WITHOUT_SSL) > > +DAEMON_MAP_DESC= Daemon Map support > > +GDBM_DESC= GDBM database backend > > That probalbly deserves a generic definition as it is wildly used in the > ports tree > There is already a generic definition for GDBM, but it didn't make sense for this port. "GNU dbm library" isn't very descriptive IMO. > > +NIS_DESC= NIS database backend > > This can problem be deneric definition (bsd.options.desc.mk) > Maybe, but I don't think this description would be fitting for most ports anyways. For this port it is meant to enable a module that reads a NIS map as the database, from what I understand. Perhaps "Network Information Service/YP support" for a generic description? > > +OPENLDAP_DESC= OpenLDAP database backend > > Why not using LDAP instead of OPENLDAP? > I wasn't aware of it...I'll change it. -- Jason E. Hale - jhale@ FreeBSD Ports Committer KDE/FreeBSD Team