From owner-freebsd-bugs@FreeBSD.ORG Wed Apr 16 09:20:00 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D6959DD5 for ; Wed, 16 Apr 2014 09:20:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B304A12BE for ; Wed, 16 Apr 2014 09:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3G9K0wR087636 for ; Wed, 16 Apr 2014 09:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3G9K0gP087626; Wed, 16 Apr 2014 09:20:00 GMT (envelope-from gnats) Resent-Date: Wed, 16 Apr 2014 09:20:00 GMT Resent-Message-Id: <201404160920.s3G9K0gP087626@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 70B08DC5 for ; Wed, 16 Apr 2014 09:18:16 +0000 (UTC) Received: from qmta02.emeryville.ca.mail.comcast.net (qmta02.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:24]) by mx1.freebsd.org (Postfix) with ESMTP id 5314E12B4 for ; Wed, 16 Apr 2014 09:18:16 +0000 (UTC) Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74]) by qmta02.emeryville.ca.mail.comcast.net with comcast id qZHL1n0041bwxycA2ZJEqJ; Wed, 16 Apr 2014 09:18:14 +0000 Received: from jdc.koitsu.org ([76.102.14.35]) by omta18.emeryville.ca.mail.comcast.net with comcast id qZJD1n0060lNtxY8eZJDQV; Wed, 16 Apr 2014 09:18:13 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 1CA4B73A1B; Wed, 16 Apr 2014 02:18:13 -0700 (PDT) Message-Id: <20140416091813.1CA4B73A1B@icarus.home.lan> Date: Wed, 16 Apr 2014 02:18:13 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: kern/188685: [cam] QUIRK: Add 4K quirks for WD Red and Black MHDDs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Jeremy Chadwick List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 09:20:01 -0000 >Number: 188685 >Category: kern >Synopsis: [cam] QUIRK: Add 4K quirks for WD Red and Black MHDDs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Apr 16 09:20:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 9.2-STABLE amd64 >Organization: >Environment: System: FreeBSD icarus.home.lan 9.2-STABLE FreeBSD 9.2-STABLE #0 r264285: Tue Apr 8 17:25:59 PDT 2014 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_9_amd64 amd64 >Description: Add some 4K quirks for the following Western Digital Caviar MHDDs: - WD Black, 4000GB, WD4003FZEX - WD Black, 3000GB, WD3003FZEX - WD Black, 2000GB, WD2003FZEX - WD Black, 1000GB, WD1003FZEX - WD Black, 500GB, WD5003AZEX (yes this really does use 4K physical) - WD Black, 2000GB, WD2002FAEX - WD Black, 1000GB, WD1002FAEX - WD Black, 4000GB, WD4001FAEX - WD Black, 3000GB, WD3001FAEX - WD Black, 2000GB, WD2001FAEX - WD Black, 1000GB, WD1001FAEX - WD Red, 750GB, WD7500BFCX (yes this really does use 4K physical) - WD Red, 1000GB, WD10JFCX Also add a comment reflecting that WD????RX also matches some models of Red drives (not listed above) and not just Green. >How-To-Repeat: n/a >Fix: Apply below patch. --- sys/cam/ata/ata_da.c.orig 2014-01-20 17:15:51.000000000 -0800 +++ sys/cam/ata/ata_da.c 2014-04-16 02:09:04.326162134 -0700 @@ -235,16 +235,31 @@ /*quirks*/ADA_Q_4K }, { + /* WDC Caviar Red Advanced Format (4k) drives */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD????CX*", "*" }, + /*quirks*/ADA_Q_4K + }, + { /* WDC Caviar Green Advanced Format (4k) drives */ { T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD????RS*", "*" }, /*quirks*/ADA_Q_4K }, { - /* WDC Caviar Green Advanced Format (4k) drives */ + /* WDC Caviar Green/Red Advanced Format (4k) drives */ { T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD????RX*", "*" }, /*quirks*/ADA_Q_4K }, { + /* WDC Caviar Red Advanced Format (4k) drives */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD??????CX*", "*" }, + /*quirks*/ADA_Q_4K + }, + { + /* WDC Caviar Black Advanced Format (4k) drives */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD??????EX*", "*" }, + /*quirks*/ADA_Q_4K + }, + { /* WDC Caviar Green Advanced Format (4k) drives */ { T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD??????RS*", "*" }, /*quirks*/ADA_Q_4K >Release-Note: >Audit-Trail: >Unformatted: