From owner-cvs-all@FreeBSD.ORG Thu Apr 13 10:57:41 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5994416A401; Thu, 13 Apr 2006 10:57:41 +0000 (UTC) (envelope-from morganw@chemikals.org) Received: from ms-smtp-01-eri0.southeast.rr.com (ms-smtp-01-lbl.southeast.rr.com [24.25.9.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A64F43D45; Thu, 13 Apr 2006 10:57:40 +0000 (GMT) (envelope-from morganw@chemikals.org) Received: from volatile.chemikals.org (cpe-024-211-118-154.sc.res.rr.com [24.211.118.154]) by ms-smtp-01-eri0.southeast.rr.com (8.13.4/8.13.4) with ESMTP id k3DAvYu4012050; Thu, 13 Apr 2006 06:57:34 -0400 (EDT) Received: from localhost (morganw@localhost [127.0.0.1]) by volatile.chemikals.org (8.13.4/8.13.4) with ESMTP id k3DAvXol065067; Thu, 13 Apr 2006 06:57:33 -0400 (EDT) (envelope-from morganw@chemikals.org) Date: Thu, 13 Apr 2006 06:57:33 -0400 (EDT) From: Wesley Morgan To: Christian Brueffer In-Reply-To: <20060413073213.GB1266@haakonia.hitnet.RWTH-Aachen.DE> Message-ID: <20060413065518.Y64934@volatile.chemikals.org> References: <200603300425.k2U4PjJH099559@repoman.freebsd.org> <20060412212843.GH1258@haakonia.hitnet.RWTH-Aachen.DE> <20060412.160552.35796990.imp@bsdimp.com> <443DB886.5010307@totalterror.net> <20060413073213.GB1266@haakonia.hitnet.RWTH-Aachen.DE> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: Symantec AntiVirus Scan Engine Cc: Niki Denev , src-committers@freebsd.org, "M. Warner Losh" , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2006 10:57:41 -0000 On Thu, 13 Apr 2006, Christian Brueffer wrote: > On Wed, Apr 12, 2006 at 10:33:42PM -0400, Niki Denev wrote: >> M. Warner Losh wrote: >>> In message: <20060412212843.GH1258@haakonia.hitnet.RWTH-Aachen.DE> >>> Christian Brueffer writes: >>> : On Thu, Mar 30, 2006 at 04:25:45AM +0000, Warner Losh wrote: >>> : > imp 2006-03-30 04:25:45 UTC >>> : > >>> : > FreeBSD src repository >>> : > >>> : > Modified files: >>> : > sys/dev/pccbb pccbb.c >>> : > Log: >>> : > On some laptops, under very high loads, the socket event register read >>> : > in the ISR doesn't read the actual socket event register, but instead >>> : > reads garbage (usually 0xffffffff, but other times other things). >>> : > This totally violates the PCI spec, but happens rarely enough that a >>> : > workaround is in order. This adds one test when we have a real >>> : > interrupt to service (which is very rare), and doesn't affect the >>> : > usualy 'nothing to see here' case at all. >>> : > >>> : > Problem reported by many, but sam@ gave me this workaround after >>> : > diagnosing the problem. >>> : > >>> : >>> : This breaks pccard/cardbus support on my Thinkpad T41p (confirmed by >>> : backing this change out). With this change, I just get an "Interrupt >>> : storm detected on irq 5; throttling" message. >>> : >>> : What kind of debug info can I provide? >>> >>> A Thinkpad T41p. :-) >>> >>> Failing that, can you set hw.cbb.debug=1 and provide me with the >>> output. >>> >>> Warner >> >> CURRENT from Monday here, on ThinkPad X31. >> I tested only with compact flash memory card, because it is the only >> that i have now, but on insert i get only this on the console : >> "Interrupt storm detected on "irq5:"; throttling interrupt source" >> I've set hw.cbb.debug to 1 before inserting the card but i got nothing more. >> >> P.S.: i have the following hw.pci. tunables in boot.conf from a long >> time ago, >> i don't know if they can affect this behaviour, but i'm giving them here >> just in case : >> >> hw.pci.do_power_nodriver=3 >> hw.pci.allow_unsupported_io_range=1 >> hw.pci.do_powerstate=1 >> > > Good to see that someone can reproduce this. Does it work again when > you back this change out? This commit broke pccard insertion detection for me as well. Backing it out restores functionality. -- This .signature sanitized for your protection