From owner-svn-src-all@freebsd.org  Wed Mar 16 15:25:31 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AB59AD2DCB;
 Wed, 16 Mar 2016 15:25:31 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249])
 by mx1.freebsd.org (Postfix) with ESMTP id D0195C41;
 Wed, 16 Mar 2016 15:25:30 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from zapp (global-5-141.nat-2.net.cam.ac.uk [131.111.5.141])
 by kif.fubar.geek.nz (Postfix) with ESMTPSA id AC812D80AA;
 Wed, 16 Mar 2016 15:24:54 +0000 (UTC)
Date: Wed, 16 Mar 2016 15:24:51 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Warner Losh <imp@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r296891 - in head/sys: cam dev/arcmsr dev/iir
 dev/isci dev/ncr dev/ppbus
Message-ID: <20160316152451.716a7e60@zapp>
In-Reply-To: <201603150517.u2F5HTkd082357@repo.freebsd.org>
References: <201603150517.u2F5HTkd082357@repo.freebsd.org>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Mar 2016 15:25:31 -0000

On Tue, 15 Mar 2016 05:17:29 +0000 (UTC)
Warner Losh <imp@FreeBSD.org> wrote:
...
> Modified: head/sys/dev/ppbus/vpo.c
> ==============================================================================
> --- head/sys/dev/ppbus/vpo.c	Tue Mar 15 04:56:39 2016
> (r296890) +++ head/sys/dev/ppbus/vpo.c	Tue Mar 15 05:17:29
> 2016	(r296891) @@ -187,17 +187,19 @@ vpo_intr(struct vpo_data
...

> @@ -307,11 +309,15 @@ vpo_action(struct cam_sim *sim, union cc
>  
>  		csio = &ccb->csio;
>  
> +		if (ccb->ccb_h.flags & CAM_CDB_PHYS) {
> +			ccb->ccb_h.status = CAM_REQ_INVALID;
> +			xpt_done(ccb);
> +			break;
> +		}
>  #ifdef VP0_DEBUG
>  		device_printf(vpo->vpo_dev, "XPT_SCSI_IO (0x%x)
> request\n",
> -			csio->cdb_io.cdb_bytes[0]);
> +		    scsiio_cdb_ptr(csio));

This is broken, scsiio_cdb_ptr returns a uint8_t * while %x expects an
int.

Andrew