From owner-svn-src-all@freebsd.org Tue Mar 20 16:44:31 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B14C0F5B796; Tue, 20 Mar 2018 16:44:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5DB847B60B; Tue, 20 Mar 2018 16:44:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 1ACC810A7DB; Tue, 20 Mar 2018 12:44:30 -0400 (EDT) From: John Baldwin To: Ed Maste Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331057 - head/sys/compat/linux Date: Tue, 20 Mar 2018 08:54:39 -0700 Message-ID: <2422935.GGHXCazita@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <201803161451.w2GEpl3T053141@repo.freebsd.org> <1806390.PUHUxB7aSs@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 20 Mar 2018 12:44:30 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 16:44:31 -0000 On Monday, March 19, 2018 05:32:22 PM Ed Maste wrote: > On 16 March 2018 at 17:08, John Baldwin wrote: > > On Friday, March 16, 2018 02:51:47 PM Ed Maste wrote: > >> Author: emaste > >> Date: Fri Mar 16 14:51:47 2018 > >> New Revision: 331057 > >> URL: https://svnweb.freebsd.org/changeset/base/331057 > >> > >> Log: > >> linux_errno.c: add newer errno values > > > > Could you move the table to a header perhaps so it can also be shared > > with lib/libsysdecode/errno.c (which has another copy of this table)? > > I found that copy shortly after I made this change (and then updated > it to match). We could just add linux_errno.c to libsysdecode though? Probably. I'd like to avoid exporting the symbol if possible. Currently that is done by marking it static in errno.c, but if I compile in linux_errno.c as-is it would be a global symbol (and would need to be exported to errno.c at least). -- John Baldwin