From owner-freebsd-current@FreeBSD.ORG  Fri Aug 14 00:53:37 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E420106568C
	for <freebsd-current@FreeBSD.org>; Fri, 14 Aug 2009 00:53:37 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A9F48FC4F
	for <freebsd-current@FreeBSD.org>; Fri, 14 Aug 2009 00:53:36 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.69) (envelope-from <amdmi3@amdmi3.ru>)
	id 1Mbl2z-0001ey-Qc; Fri, 14 Aug 2009 04:53:33 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 71C71B860;
	Fri, 14 Aug 2009 04:53:32 +0400 (MSD)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 6AD34108842; Fri, 14 Aug 2009 04:53:24 +0400 (MSD)
Date: Fri, 14 Aug 2009 04:53:24 +0400
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Julian Elischer <julian@elischer.org>
Message-ID: <20090814005324.GA1552@hades.panopticon>
References: <20090801022523.GA93222@hades.panopticon>
	<4A84A901.4010109@elischer.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4A84A901.4010109@elischer.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-current@FreeBSD.org
Subject: Re: panic in ipfw with recent current
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2009 00:53:37 -0000

* Julian Elischer (julian@elischer.org) wrote:

> found the fix I think..
> 
> in line 2061 of ip_fw2.c in the crhold()
> the argument should be pcb->inp_cred, not inp->cred
> 
> 2059        if (pcb != NULL) {
> 2060              *uc = crhold(inp->inp_cred); <--s/inp/pcb/
> 2061              *ugid_lookupp = 1;
> 2062        }

Confirmed, this fixes the problem. Filtering by gid works and no
panics. Thanks a lot!

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru