From owner-svn-src-head@FreeBSD.ORG  Thu Aug 12 15:03:38 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 495EA10656A6;
	Thu, 12 Aug 2010 15:03:38 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 060FF8FC14;
	Thu, 12 Aug 2010 15:03:37 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id CFAB21FFC33;
	Thu, 12 Aug 2010 15:03:36 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 85AA18454D; Thu, 12 Aug 2010 17:03:36 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Takanori Watanabe <takawata@FreeBSD.org>
References: <201008121358.o7CDwk0d098768@svn.freebsd.org>
Date: Thu, 12 Aug 2010 17:03:36 +0200
In-Reply-To: <201008121358.o7CDwk0d098768@svn.freebsd.org> (Takanori
	Watanabe's message of "Thu, 12 Aug 2010 13:58:46 +0000 (UTC)")
Message-ID: <86pqxn50vr.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r211221 - head/usr.sbin/acpi/acpidump
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Aug 2010 15:03:38 -0000

Takanori Watanabe <takawata@FreeBSD.org> writes:
> -	printf("\tClass %d Base Address 0x%jx Length %llu\n\n",
> +	printf("\tClass %d Base Address 0x%jx Length %" PRIu64 "\n\n",
>  	    tcpa->platform_class, paddr, len);

This is just as wrong as the previous attempt.

1) platform_class is not an int.
2) paddr is not a uintmax_t.
3) so far, we've avoided using the PRI macros.

Slightly better:

	printf("\tClass %u Base Address 0x%jx Length %ju\n\n",
  	    (unsigned int)tcpa->platform_class, (uintmax_t)paddr, (uintmax_t)len=
);

but it would probably be easier to define paddr and len as unsigned long
long instead of the misspelled u_int64_t, and use %llx and %llu.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no