From owner-freebsd-current@freebsd.org Mon Nov 30 20:28:47 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDAC0A3CEAE for ; Mon, 30 Nov 2015 20:28:47 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D1A501DAD; Mon, 30 Nov 2015 20:28:47 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.200.208] (unknown [50.136.155.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id AF56A192AD1; Mon, 30 Nov 2015 20:28:39 +0000 (UTC) Subject: Re: sys/modules "make clean" seems broken again To: Warner Losh , John Baldwin References: <564E0322.8050308@freebsd.org> <3514235.7QMnNNElsE@ralph.baldwin.cx> Cc: FreeBSD Current From: Sean Bruno Message-ID: <565CB176.4070906@freebsd.org> Date: Mon, 30 Nov 2015 12:28:38 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 20:28:48 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 11/19/15 15:42, Warner Losh wrote: > > > On Thu, Nov 19, 2015 at 11:12 AM, John Baldwin > wrote: > > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote: >> I thought I fixed this a year or two ago, but now a "make clean" >> in sys/modules seems to leave bus_if.h device_if.h and pci_if.h >> in the directory. >> >> Should I just add these to the clean targets? > > Blame Warner as his MFILES changes broke this. In particular, see > r287263 which turned off cleaning these up. I'm not sure what that > broke that caused it to be disabled. > > Your change is a gross hack though. > > > Yes. The reason I had to break it was that there were a few files > named _if.c and _if.h in the tree that would get deleted when make > clean was run in the modules. > > I'll take another run at fixing this. Sean's "fix" is a horrible > hack. > > Warner Just bouncing a ping here. I haven't actually checked to see if the last weeks' commits to head fixed this, but I suspect this hasn't been addressed. What do we want to do different if not this hackery I propose? sean -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJWXLFzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kQGgH/0f9VFqsC2v/CxFSn/oB+n8t 6OwiSZzCQ6D9DQJ259kTFPUXBpOvoDOCrmqxklx0dPov9X9np601CtYlLdz3Ozrk P3Pg6KrxAq9dZU2TGMm3SSsho6LTvPJ93Up+m0ekk8KRmhntemk1AoUtxShrUFZi OdEaSxWFfar1cc/6UYhtqXmKcBZXnxdQGkVe0aFCJJDCyuCLWMuIXSO+vjHWvFYF NUj2fhBHfr1PNX1Hao4j4aR3VfUpLTDclfW0f8e3ABJo2cQ07w935kCPkZQau/8f ongD795281LJdgamYtB/A0r63xQgzXqeJV6Gk0SRTXU75NUArWfGiweEtMd6wfw= =RB/W -----END PGP SIGNATURE-----