Date: Wed, 22 Jan 2014 19:00:58 -0500 From: Julio Merino <julio@meroh.net> To: Alan Somers <asomers@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: PATCH: fix "WITH_TESTS=yes make installworld" on amd64 Message-ID: <B416224C-79BF-4C8D-B282-0A1042DD9CE4@meroh.net> In-Reply-To: <CAOtMX2jvBirXFSha7FTvsszQFfjVjWOLdfWEeky3VXnEE0Krjg@mail.gmail.com> References: <CAOtMX2jvBirXFSha7FTvsszQFfjVjWOLdfWEeky3VXnEE0Krjg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 21, 2014, at 13:00, Alan Somers <asomers@freebsd.org> wrote: > I finally found the problem. Make was trying to install tests during > the install32 phase. During this phase, it adds "lib32" to > MAKEOBJDIRPREFIX, so it can't find the tests, which were never built > with that prefix. The command worked fine when I ran it under "make > buildenv", because that uses the normal MAKEOBJDIRPREFIX. >=20 > I'm not sure what prevented the tests from being built during the > lib32 build phase, but this patch will disable tests during both > building and installing 32 bit libraries. >=20 > At work, we never noticed this problem in our SpectraBSD branch > because we set WITHOUT_LIB32=3D1 in /etc/src.conf. >=20 >=20 > Does this patch look ok? Yes it does. Can you commit and merge into stable/10 please? (This is the issue I mentioned in your other email a little bit earlier, = before seeing this other email. Glad to see we reached the same = conclusion :-) You'll notice that the testing cluster was cheating on this area if you = look at line 17 below :-P = http://svnweb.freebsd.org/base/user/jmmv/autotest/node/configs/kyua1/head.= conf?revision=3D260453&view=3Dmarkup=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B416224C-79BF-4C8D-B282-0A1042DD9CE4>