From owner-p4-projects@FreeBSD.ORG  Tue Feb 17 07:35:52 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CEA471065673; Tue, 17 Feb 2009 07:35:51 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8EBDB1065670
	for <perforce@freebsd.org>; Tue, 17 Feb 2009 07:35:51 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D1468FC19
	for <perforce@freebsd.org>; Tue, 17 Feb 2009 07:35:51 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n1H7Zp9s000731
	for <perforce@freebsd.org>; Tue, 17 Feb 2009 07:35:51 GMT
	(envelope-from andrew@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n1H7ZpoI000728
	for perforce@freebsd.org; Tue, 17 Feb 2009 07:35:51 GMT
	(envelope-from andrew@freebsd.org)
Date: Tue, 17 Feb 2009 07:35:51 GMT
Message-Id: <200902170735.n1H7ZpoI000728@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	andrew@freebsd.org using -f
From: Andrew Turner <andrew@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 157831 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Feb 2009 07:35:53 -0000

http://perforce.freebsd.org/chv.cgi?CH=157831

Change 157831 by andrew@andrew_bender on 2009/02/17 07:35:46

	Only set SER_INT_TXIDLE when we are busy.
	This if statement could be removed as we are never busy as s3c2410_putc will block when the FIFO is not empty which means we only ever have 1 character in it.

Affected files ...

.. //depot/projects/arm/src/sys/arm/s3c2xx0/uart_dev_s3c2410.c#8 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/s3c2xx0/uart_dev_s3c2410.c#8 (text+ko) ====

@@ -254,7 +254,6 @@
 		s3c2410_putc(&sc->sc_bas, sc->sc_txbuf[i]);
 		uart_barrier(&sc->sc_bas);
 	}
-	sc->sc_txbusy = 1;
 	uart_unlock(sc->sc_hwmtx);
 
 	return (0);
@@ -298,7 +297,7 @@
 	utrstat = uart_getreg(&sc->sc_bas, SSCOM_UTRSTAT);
 	uart_unlock(sc->sc_hwmtx);
 
-	if ((utrstat & UTRSTAT_TXEMPTY) == UTRSTAT_TXEMPTY) {
+	if ((utrstat & UTRSTAT_TXEMPTY) == UTRSTAT_TXEMPTY && sc->sc_txbusy != 0) {
 		ipend |= SER_INT_TXIDLE;
 	}
 	if ((utrstat & UTRSTAT_RXREADY) == UTRSTAT_RXREADY) {
@@ -325,6 +324,7 @@
 {
 	return (EINVAL);
 }
+
 struct uart_class uart_s3c2410_class = {
 	"s3c2410 class",
 	s3c2410_methods,