From owner-freebsd-bugs@FreeBSD.ORG Mon Sep 30 19:31:43 2013 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 15240D27; Mon, 30 Sep 2013 19:31:43 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F24112F48; Mon, 30 Sep 2013 19:31:42 +0000 (UTC) Received: from zeta.ixsystems.com (unknown [69.198.165.132]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 8979D27D3F; Mon, 30 Sep 2013 12:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1380569502; bh=dKpRJHQ2coQyZyk6pe/yaZfLjCKuLX4vO9OH6xASxZU=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=n+3+0+CZ/CirQHqf/A1wUlXvx2I6kvdSg7jfgr7dmcQ1EoM3ljPVIKpPcBX4dZXdY yqcClS8ZyiN88XPIbYzdeONcaVidP6cVi7BgF9ILF3U9ViSeGN7pvm8GUKSWtsdLBt ZGUE4qKkD46vLuQ5pT5spIQIkYDYcdV8YOvocyjE= Message-ID: <5249D19E.6000303@delphij.net> Date: Mon, 30 Sep 2013 12:31:42 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: Jeremy Chadwick , delphij@FreeBSD.org Subject: Re: bin/182360: nslookup emits SIGSEGV when Ctrl-D (EOF) pressed References: <201309252042.r8PKgPQ5011485@freefall.freebsd.org> <20130930014445.GA88757@icarus.home.lan> In-Reply-To: <20130930014445.GA88757@icarus.home.lan> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-bugs@FreeBSD.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Sep 2013 19:31:43 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 09/29/13 18:44, Jeremy Chadwick wrote: > On Wed, Sep 25, 2013 at 08:42:25PM +0000, delphij@FreeBSD.org > wrote: >> Synopsis: nslookup emits SIGSEGV when Ctrl-D (EOF) pressed >> >> State-Changed-From-To: open->patched State-Changed-By: delphij >> State-Changed-When: Wed Sep 25 20:41:38 UTC 2013 >> State-Changed-Why: Fixed in -HEAD, MFC reminder. >> >> (Note that it's too late to fix this for 9.2-RELEASE). >> >> >> Responsible-Changed-From-To: freebsd-bugs->delphij >> Responsible-Changed-By: delphij Responsible-Changed-When: Wed Sep >> 25 20:41:38 UTC 2013 Responsible-Changed-Why: Take. >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=182360 > > Should HEAD r255873 be reverted as a result of HEAD r255891? I don't think so (note that BIND is now removed from HEAD so there is nothing to revert anyways). See below. > I see HEAD r255891 got MFC'd (as r255924) -- thank you. I had a > feeling the issue was in libedit but wasn't entirely certain which > was the proper place to fix it. > No. The libedit change was a bug for bandaid one so using libedit in place of readline won't crash. The original GNU readline example [1] reads: /* If the line has any text in it, save it on the history. */ if (line_read && *line_read) add_history (line_read); Normally the documented example is the recommended practice of how to use the library API. Note that neither libedit or readline handles the case where add_history("") is called specially. The BIND code was changed to match this but since the change is no longer a critical one with the libedit change, I will leave the stable branch as-is for now and see how far my bug report to ISC would go. [1] http://cnswww.cns.cwru.edu/php/chet/readline/readline.html#SEC24 Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQEcBAEBCgAGBQJSSdGeAAoJEG80Jeu8UPuzr+cH/34VyMylduiyWTJXrfYgqxfM ZxskvLVQKIZF47+Ie9HmfBUXLFG/UiJut1xsHf6mhMFhSLK7TVV+vWlkuJSMohI+ dQd+/fPOvk1tVuiY4LBNruPAoXDDNEV/KuhcdIs+GEOYH6yfNhDSzcxkLOoNmBRD UcnrMDFELzTD7bn9qWj3WuWOocDvvGu+Vbbjjne6g1nFw1mw2G5hBf+09dd4hfxF K2Alno/GfZGK3mMSOyIl8lzVHQ5jiCmbzMoJ4EXry45AsLswL4g1KffQ6Ii9CtUk tzhFmK0Jeu+kplk6gr9bUMiukO1MDBsTHZTfIQBSxdiMziC3l4GPYRP3gLV4e8E= =C2Cm -----END PGP SIGNATURE-----