From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 30 10:30:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id EBFE69A2 for ; Wed, 30 Oct 2013 10:30:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CA66B24BC for ; Wed, 30 Oct 2013 10:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9UAU0sN061738 for ; Wed, 30 Oct 2013 10:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9UAU04K061726; Wed, 30 Oct 2013 10:30:00 GMT (envelope-from gnats) Resent-Date: Wed, 30 Oct 2013 10:30:00 GMT Resent-Message-Id: <201310301030.r9UAU04K061726@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 34878878 for ; Wed, 30 Oct 2013 10:23:05 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.114.190]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E6F362469 for ; Wed, 30 Oct 2013 10:23:04 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1VbSvW-0005xj-96 for FreeBSD-gnats-submit@freebsd.org; Wed, 30 Oct 2013 14:23:02 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id D6D348E1 for ; Wed, 30 Oct 2013 14:23:01 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id C3B2CFA1; Wed, 30 Oct 2013 14:23:01 +0400 (MSK) Message-Id: <20131030102301.C3B2CFA1@hades.panopticon> Date: Wed, 30 Oct 2013 14:23:01 +0400 (MSK) From: Dmitry Marakasov To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/183470: [options] support multivalue sets in ${opt}_USE X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 10:30:01 -0000 >Number: 183470 >Category: ports >Synopsis: [options] support multivalue sets in ${opt}_USE >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 30 10:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 9.1-RELEASE-p4 amd64 >Organization: >Environment: System: FreeBSD hades.panopticon 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0 r251956: Tue Jun 18 21:41:37 MSK 2013 root@hades.panopticon:/usr/obj/usr/src/sys/HADES amd64 >Description: Currently, framework won't support OPTIONS_DEFINE= X11 X11_USE= XORG="x11 sm ice" because it considers "x11 sm ice" a single value. The patch attached removes quites so above code works as expected. While here, I'd like to suggest to merge USE_* with USES, so the code below work: USES= gettext gmake XORG="x11 sm ice" QT="corelib gui" OPTIONS_DEFINE= OGL OGL_USE= GL="gl glu" >How-To-Repeat: >Fix: --- bsd.options.mk.patch begins here --- Index: Mk/bsd.options.mk =================================================================== --- Mk/bsd.options.mk (revision 332092) +++ Mk/bsd.options.mk (working copy) @@ -387,7 +387,7 @@ . if defined(${opt}_USE) . for option in ${${opt}_USE} _u= ${option:C/=.*//g} -USE_${_u:U}+= ${option:C/.*=//g} +USE_${_u:U}+= ${option:C/.*=//g:C/^"//:C/"$$//} . endfor . endif . if defined(${opt}_CONFIGURE_ENABLE) --- bsd.options.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: