From owner-svn-src-head@freebsd.org Sat Mar 28 03:22:19 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB63B26E479; Sat, 28 Mar 2020 03:22:19 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48q3tf2pGLz3CBj; Sat, 28 Mar 2020 03:22:18 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id EF3703C0199; Sat, 28 Mar 2020 03:22:09 +0000 (UTC) Date: Sat, 28 Mar 2020 03:22:09 +0000 From: Brooks Davis To: Enji Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359385 - head/usr.bin/kyua Message-ID: <20200328032209.GA40889@spindle.one-eyed-alien.net> References: <202003280108.02S18KWc062782@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <202003280108.02S18KWc062782@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 48q3tf2pGLz3CBj X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2020 03:22:19 -0000 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote: > Author: ngie > Date: Sat Mar 28 01:08:20 2020 > New Revision: 359385 > URL: https://svnweb.freebsd.org/changeset/base/359385 >=20 > Log: > Check in the generated copies of the manpages > =20 > These manpages were meant to be templated once per `configure` run. > =20 > Given that we're not bound by as many constants, e.g., `--prefix` isn't > generally changing for kyua in the base system, having to generate the > manpages each build seems slightly less than optimal. > =20 > In the event that one's build environment doesn't define `$SH`, the bui= ld > will also fail until this change is introduced. > =20 > Instead of jumping through hoops dealing with shells or permissions, le= t's > just cut to the chase and check the generated copies into the sourcebase > under usr.bin/kyua . This was the wrong fix. Committing generated manpaged was 100% the wrong solution and will make extra work in the future. The correct fix is almost certainly the one attached to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245086. If someone doesn't beat me to it I will revert you wrong and broken commit along with the followups and commit the correct one (this certainly won't be until at least tomorrow). -- Brooks --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJefsLhAAoJEKzQXbSebgfA81kH+wX7ZJZ+Yopu1JlXD6e4jNqL NLRv73raJh0tBaL9XQkqgxqv7jnSrwd7qKZuKVxN50zv0Fa5sZsVoJWfUEiRJlyK m5QWUyXdBA38z3SAeY3zW5R/j20vHGYEacLp9ox3dc2nkPfa4TjyesHEtkDFGGqP R6Vn7llr2t4QG+w1szjzLEZJMiNcLN9//HAF4N9a4htwVbH/aejJxhmFbQY+ss9j yliN2KizzeGo0ICQvcgfmRcZ38EpxeSPJEgcdw85izOx9ybs2aFw0jgzgBDlrcc8 TeSijKGzHJvunxgSo15V/eaeQrxNJtjXftB7Yn8twW05DsaDEoTgOJhw6Zzzo7Q= =ngTc -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--