From owner-svn-src-all@freebsd.org Tue Jun 16 17:01:11 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F0C0E3443A1 for ; Tue, 16 Jun 2020 17:01:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound5a.ore.mailhop.org (outbound5a.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49mZGb25JNz4NB5 for ; Tue, 16 Jun 2020 17:01:11 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1592326864; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=XqMv++iO0yzx2lt+38yYO64ZdNAbcfT0rWDJuoCbI1+3AAQ1WZhnaXFYXlg6rcz4i9zYdjBr2eQ8E 63ohE3N2Pvj+e0vFCjL3ftyDEXC/2VYkkGMqkfxkSKT1WHH1E4jcD7BNjy5kNjh4LFo7iEutkcwhKI U5k4URnJhm2fUiqGm/5cJTrYbbd6GzzQFfAn6pHz6LySDahB3wnGO5BEEHqBof7Kxn2F8Tqy8Mw3C3 qVdYOLNH94AkIeA8f8GWLCh4q9WvqFYOXsFMKx54itnwKpOJwg1AjK4OeSKMr4UgzE0CpJbhNluDfp wXdVihXQXzT+G7LuZMFsYfidhWHuiwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=IElVbtlvOPe5q5w4ZuyqH4cDrF4xi3OE5/TC/C28KGE=; b=DJdRBJMwGRtEcz4y1urtKMgqbgJEvC+xW1GeYYQK8Rjld9uWcaXxrlYkmzFortPanBfJc17Ze36JU AGFdVT9++Ch4IJ/xYs7VsuEGZVKgl0hhGUD5k6oWe1WzEdq5t+g1+7gEfggrIXrQ8VpcKznhx5OMiZ E6+gR90f9v11OtHDPdNszqERTGc/xFSrFoezpSomzXOILjhGxipLvOpxMBstQOTYAXql91v/jnzcng cL6uO5Rxoyd8abJXmfW7Hh5MlzHPpeQfAxUmJpDCmTl5+NJRw0BGB7OxwAGp29cKfk6ZQym5hswMXO eYt9l4Lma0ghd+d8J+nFNrQ6bkpQoMA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=IElVbtlvOPe5q5w4ZuyqH4cDrF4xi3OE5/TC/C28KGE=; b=kT/Saov9aAczVEhLFIe3tFQ5sMfdA0gZ3Ega46xMDwGIUOfDQdWa79DOfIjGeos6oSXBeFyjTH/VB VrKWTS1hUokxpDqWatugpRMz/vnwnq9sp579bhgJm0poN6HgkGumgjv9gybY78zGh/upzEdMxNKIGb hv02+IHmOLzxyyIciJBkrc34o8NryqdSSO5zcmpz4p7Tm5ZT1cJ8AqFDa8pDJOvxnqY1AQ1da10i1D z1PZqYZ6DOqOgMVaBggT0wB4FJQm19Ht++FUyfeI58v1eksy7zJ+omFsOSsmBmlLNSWttkrFK7gIXA 7Jq17RvKo4cZsOoPDJa3irZVKbqxqsA== X-MHO-RoutePath: aGlwcGll X-MHO-User: f57921e8-aff2-11ea-b10c-b5956a7dd1a1 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id f57921e8-aff2-11ea-b10c-b5956a7dd1a1; Tue, 16 Jun 2020 17:01:03 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 05GH12uo025322; Tue, 16 Jun 2020 11:01:02 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> Subject: Re: svn commit: r362217 - head/stand/common From: Ian Lepore To: Toomas Soome , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 16 Jun 2020 11:01:02 -0600 In-Reply-To: <202006160705.05G753T4057972@repo.freebsd.org> References: <202006160705.05G753T4057972@repo.freebsd.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49mZGb25JNz4NB5 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:16509, ipnet:44.224.0.0/11, country:US]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 17:01:12 -0000 On Tue, 2020-06-16 at 07:05 +0000, Toomas Soome wrote: > Author: tsoome > Date: Tue Jun 16 07:05:03 2020 > New Revision: 362217 > URL: https://svnweb.freebsd.org/changeset/base/362217 > > Log: > loader: variable i is unused without MBR/GPT support built in > > Because i is only used as index in for loop, declare it in for > statement. > As much as I prefer doing it this way, style(9) doesn't allow for variable declarations inside a for() statement (or even inside a local block, which is just too 1980s for me, but it is still our standard). -- Ian