Date: Tue, 7 Apr 2020 15:30:59 +0300 From: Lev Serebryakov <lev@FreeBSD.org> To: "Andrey V. Elsukov" <bu7cher@yandex.ru>, Neel Chauhan <neel@neelc.org>, freebsd-hackers@freebsd.org Subject: Re: Committing one ipfw(8) userland patch Message-ID: <ed3a9bec-e5ef-2f2b-ee90-5f68239a66dd@FreeBSD.org> In-Reply-To: <49c316d5-73e1-a5df-cd15-a35cc9e61420@yandex.ru> References: <d69a1edea314bb0f15e10b9750292806@neelc.org> <49c316d5-73e1-a5df-cd15-a35cc9e61420@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qqeeXeDNanuhBu80GKrMwhrDP6qafrmmI Content-Type: multipart/mixed; boundary="V4og1aXbEJz7UZ74IzElza23x2Om1x5W8" --V4og1aXbEJz7UZ74IzElza23x2Om1x5W8 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07.04.2020 11:28, Andrey V. Elsukov wrote: >> I have one patch for the ipfw userland tool: >> https://reviews.freebsd.org/D24234 >> >> This patch adds the src-ip4/dst-ip4 and src-ipv4/dst-ipv4 aliases for >> src-ip/dst-ip commands respectively in IPFW. >> >> Could someone please commit this patch? >=20 > Can you describe what is the benefit to have all these aliases, when > after adding the rule you will still see other name. I think this makes= > it more confusing. I think, {src|dst}-ip without version should exist only for backward compatibility and, maybe, produce warnings. Why? symmetry & consistency. And equal length of fields in rules for different versions, too :-) Also, there are confusion with me/me4/me6. When `src-ip` is really `src-ip4`, what does `me` mean? `me4`? or `me4 OR me6`? --=20 // Lev Serebryakov --V4og1aXbEJz7UZ74IzElza23x2Om1x5W8-- --qqeeXeDNanuhBu80GKrMwhrDP6qafrmmI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE+W0coLX0MYtnSzMK6rA8WL/cR48FAl6McoNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 NkQxQ0EwQjVGNDMxOEI2NzRCMzMwQUVBQjAzQzU4QkZEQzQ3OEYACgkQ6rA8WL/c R4/O5BAAiqVRFKqGBoLNIBCSgNNu8jyk/RHP1aIXMD4eyreaOovDQcPD0tvBNcA2 36fFwCST9wPNlfvQfRP4DdEafS8LcbUfsn4jxSTlST4mjkdcKiVkk/iTR8WA3K/v kkG3lNiIGyOyMMHqmddq2Jb5GomFyI7Nw5sJmsoKSJ4j0O4Z/Axc3ZEqO2Rf3SRZ C22LfpLpUlVeZ4drmr3sP3G9QjHUz8S9Sxz6DG0Lb6TIE5EWaqnUhpFSjmSBrcFO klz6jIiykXNEt6Hc5MH66PTF2s0UhF1tn3ALB3SD+ysyLUznQ+wxHc7LPLGzMOcA cqQirFNE0lGCKREVyAu+VKEj36EjK2AllTmZv0BoeD8ImhJaIdnVaUeh9o2cdSpr EszBuZYuRpx0vXgYAFljASO/1xDgY0Tf8iQfXfqCRD6kYVEf7N7Ha3RgBzbSvnbF LAfaWYVfuJUWaYnQMv7jpFC+d+kyh5vF/gc1Civ+fU80RxKUBFpQwPnBHAraKMN8 QDWUsvNtRhpc1RsNfFTM2jsTU2ULkm6to2Mo6w9FrJoZccCth7DrLsJbcxvFjuO7 sTJHgmTxWOU79RsMoruGaBuALcJxPu6eWtXtwRHgdGfZzhNCtKnGa+TJ8Esb8sAb bMfCSDrgz1VrBch4xAbfMP0bctySP7GG+mP7zAF3yW2McUImz5c= =yaM9 -----END PGP SIGNATURE----- --qqeeXeDNanuhBu80GKrMwhrDP6qafrmmI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed3a9bec-e5ef-2f2b-ee90-5f68239a66dd>