From owner-freebsd-hackers@FreeBSD.ORG Wed Feb 15 17:09:23 2006 Return-Path: X-Original-To: hackers@freebsd.org Delivered-To: freebsd-hackers@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FDF616A420 for ; Wed, 15 Feb 2006 17:09:23 +0000 (GMT) (envelope-from q@galgenberg.net) Received: from wrzx28.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C19643D49 for ; Wed, 15 Feb 2006 17:09:21 +0000 (GMT) (envelope-from q@galgenberg.net) Received: from virusscan.mail (amavis1.rz.uni-wuerzburg.de [132.187.3.48]) by wrzx28.rz.uni-wuerzburg.de (Postfix) with ESMTP id 0C7F5D84FD; Wed, 15 Feb 2006 18:09:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id F17BE10EF; Wed, 15 Feb 2006 18:09:20 +0100 (CET) Received: from frodo.galgenberg.net (wwsx14.win-screen.uni-wuerzburg.de [132.187.253.14]) by wrzx28.rz.uni-wuerzburg.de (Postfix) with ESMTP id 82456D84FD; Wed, 15 Feb 2006 18:09:20 +0100 (CET) Received: from coyote.q.local (gb-21-237.galgenberg.net [172.16.21.237]) by frodo.galgenberg.net (8.13.1/8.13.1) with ESMTP id k1FH9Kag089897; Wed, 15 Feb 2006 18:09:20 +0100 (CET) (envelope-from q@galgenberg.net) Received: from roadrunner.q.local (roadrunner.q.local [192.168.0.148]) by coyote.q.local (8.13.4/8.13.4) with ESMTP id k1FH9KhQ022352; Wed, 15 Feb 2006 18:09:20 +0100 (CET) (envelope-from q@galgenberg.net) Received: from roadrunner.q.local (localhost [127.0.0.1]) by roadrunner.q.local (8.13.4/8.13.4) with ESMTP id k1FH9KB5006823; Wed, 15 Feb 2006 18:09:20 +0100 (CET) (envelope-from q@galgenberg.net) Received: (from q@localhost) by roadrunner.q.local (8.13.4/8.13.4/Submit) id k1FH9JX2006775; Wed, 15 Feb 2006 18:09:19 +0100 (CET) (envelope-from q@galgenberg.net) Date: Wed, 15 Feb 2006 18:09:19 +0100 From: Ulrich Spoerlein To: Dan Nelson Message-ID: <20060215170919.GB1123@galgenberg.net> Mail-Followup-To: Dan Nelson , hackers@freebsd.org References: <20060214212503.GE1107@galgenberg.net> <20060215080532.GB684@turion.vk2pj.dyndns.org> <20060215150237.GA1123@galgenberg.net> <20060215160524.GA70956@dan.emsphone.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ycz6tD7Th1CMF4v7" Content-Disposition: inline In-Reply-To: <20060215160524.GA70956@dan.emsphone.com> X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Cc: hackers@freebsd.org Subject: Re: Naive implementation of strverscmp(3) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2006 17:09:23 -0000 --Ycz6tD7Th1CMF4v7 Content-Type: multipart/mixed; boundary="4ZLFUWh1odzi/v6L" Content-Disposition: inline --4ZLFUWh1odzi/v6L Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Dan Nelson wrote: >This looks a lot like strnatcmp, which is "natural sort" or "do what I >mean" sort :) > >http://sourcefrog.net/projects/natsort/ Heh, I didn't know about that one, but since gqview uses strverscmp I=20 only google for that one. >Your function is simpler than the C implementation on that site, but >falls over when a run of numbers exceeds 2^31 (raise it to 2^64 if you >use strtoull, but that's as high as you can yet). That's true, I didn't think of that. It's funny how a simple function=20 like comparing alphanumerical strings can cause that much trouble. Anyway, attached is a last version, which now also functions for strings=20 starting with numbers and which I'll probably try getting committed to=20 the gqview port. You may do with the code whatever you want. :) Ulrich Spoerlein --=20 PGP Key ID: 20FEE9DD Encrypted mail welcome! Fingerprint: AEC9 AF5E 01AC 4EE1 8F70 6CBD E76E 2227 20FE E9DD Which is worse: ignorance or apathy? Don't know. Don't care. --4ZLFUWh1odzi/v6L Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="strverscmp.c" Content-Transfer-Encoding: quoted-printable #include #include #include #include #ifdef __FreeBSD__ int strverscmp(const char *s1, const char *s2); int strverscmp(const char *s1, const char *s2) { static const char *digits =3D "0123456789"; char *t1, *t2; int ret; long n1, n2; size_t p1, p2; p1 =3D strcspn(s1, digits); p2 =3D strcspn(s2, digits); while (p1 =3D=3D p2 && s1[p1] !=3D '\0' && s2[p2] !=3D '\0') { /* Different prefix */ if ((ret =3D strncmp(s1, s2, p1)) !=3D 0) return ret; s1 +=3D p1; s2 +=3D p2; n1 =3D strtol(s1, &t1, 10); n2 =3D strtol(s2, &t2, 10); =20 if (n1 < n2) return -1; else if (n1 > n2) return 1; /* One number is "shorter", e.g., "07" vs "007" */ if (t1-s1 < t2-s2) return 1; else if (t1-s1 > t2-s2) return -1; /* Numbers are equal or not present, try with next ones. */ s1 =3D t1; s2 =3D t2; p1 =3D strcspn(s1, digits); p2 =3D strcspn(s2, digits); } =20 return strcmp(s1, s2); } #endif int main(int argc, char **argv) { char **array, *temp; int i, j, n =3D 10; array =3D (char **) calloc(n, sizeof(char *)); array[0] =3D strdup("10.jpg"); array[1] =3D strdup("2.jpg"); array[2] =3D strdup("1.jpg"); array[3] =3D strdup("09.jpg"); array[4] =3D strdup("a01b2"); array[5] =3D strdup("a1b1"); array[6] =3D strdup("a"); array[7] =3D strdup("1.001"); array[8] =3D strdup("1.1"); array[9] =3D strdup("1.01"); /* Bubble sort */ for (i=3D0; i 0) { temp =3D array[j]; array[j] =3D array[i]; array[i] =3D temp; } } } for (i=3D0; i 0\n", strverscmp("alpha1", "alpha001")); printf("%d > 0\n", strverscmp("part1_f012", "part1_f01")); printf("%d < 0\n", strverscmp("foo.009", "foo.0")); return 0; } --4ZLFUWh1odzi/v6L-- --Ycz6tD7Th1CMF4v7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD82A/524iJyD+6d0RAraQAKCUDQ73nYHAsNOzzRxWxHFV7pNJmwCdGd4J zHCLxsexnK2PMzL61wt4ALQ= =maYq -----END PGP SIGNATURE----- --Ycz6tD7Th1CMF4v7--