From owner-freebsd-net@FreeBSD.ORG Tue Sep 4 18:22:44 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 220D716A41A; Tue, 4 Sep 2007 18:22:44 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id 8765113C4D0; Tue, 4 Sep 2007 18:22:43 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 66C30690FA0; Tue, 4 Sep 2007 19:27:11 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id F0C7C691095; Tue, 4 Sep 2007 19:27:10 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO autolearn=ham version=3.1.7 Received: from epsilon.local (62.169.122.58.rev.optimus.pt [62.169.122.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by core.fnop.net (Postfix) with ESMTP id 7E126690FA0; Tue, 4 Sep 2007 19:27:06 +0100 (WEST) Message-ID: <46DDA265.2090500@fnop.net> Date: Tue, 04 Sep 2007 19:22:29 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Andre Oppermann References: <46DCB831.3030207@fnop.net> <46DD59F9.1080107@freebsd.org> In-Reply-To: <46DD59F9.1080107@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: freebsd-net@freebsd.org Subject: Re: Killing IPTOS_CE and IPTOS_ECT X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2007 18:22:44 -0000 Andre Oppermann wrote: > Rui Paulo wrote: >> Hi, >> I'm working on TCP ECN support and I would like to kill these defines >> from netinet/ip.h >> >> #if 1 >> /* ECN RFC3168 obsoletes RFC2481, and these will be deprecated soon. */ >> #define IPTOS_CE 0x01 >> #define IPTOS_ECT 0x02 >> #endif >> >> The are outdated and should no longer be used because that RFC has >> been obsoleted. RFC 3168 uses a bit different bits: >> #define IPTOS_ECN_NOTECT 0x00 /* not-ECT */ >> #define IPTOS_ECN_ECT1 0x01 /* ECN-capable transport (1) */ >> #define IPTOS_ECN_ECT0 0x02 /* ECN-capable transport (0) */ >> #define IPTOS_ECN_CE 0x03 /* congestion experienced */ >> #define IPTOS_ECN_MASK 0x03 /* ECN field mask */ >> >> The only consumer of the RFC 2481 defines is sbin/ipfw/ipfw2.c and >> luigi@ accepted the attached patch. >> >> Does anyone have any objection against the removal ? > > No. Please produce a complete unified diff patch including both > the changes to ip.h and ipfw2.c, a sufficiently verbose commit > message, the result a complete make universe build run with the > patch applied to otherwise clean sources and send it to re@ and > me in CC. If approved I commit it for you. Well, I was asking for comments regarding on the usage of these flags. I was hoping to commit ip.h along with TCP ECN. This doesn't really need to be before the branch, I think. -- Rui Paulo