From nobody Thu Sep 11 16:57:26 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cN3dc2d5Nz66vw8 for ; Thu, 11 Sep 2025 16:57:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cN3dc0gyGz3T0r for ; Thu, 11 Sep 2025 16:57:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-32ddfe3c8ccso661499a91.3 for ; Thu, 11 Sep 2025 09:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1757609858; x=1758214658; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0H793k325/i6ztrh5q9U52l/kF+m8w7eJ0fk4C1Iydk=; b=pGIWgsBzAnvvYMwLSous4FTDyk4QlI+PgyvTpg14ELxQZbSZj2alPyRQxa7fgMNStB +Ep/qFFdq5vBljsfePiRS0Wumi4bS4cab3p1MyN+bIq77QsNN7fKPVjyCyaxpWJUDK2U D1mttVqEkUxP1iS5+HbAmRLoInGEJvU4acRY73y7l6zAybiydw+BJTk4mpH0DUkKXnn2 J0Tj9aijMQepJm/7d6liw9RTbIgzR6E/MN0HESkY6weUOS1HNJ5FsXPBZW34amiatHss FkNfcLj2UvsvnzUQV7+5GUfRIEVc1TJ7E55X7Z1+7JemqQ7uN/u096fxRVBzZh3Wge9G bdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757609858; x=1758214658; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0H793k325/i6ztrh5q9U52l/kF+m8w7eJ0fk4C1Iydk=; b=DBfybCU64TQdzBS3NCJVE/hsibA+XT0yvGwiUBBwMwwJPsLk9BGQ04P3FPo2w43A6A nsBg4WU2A1YsGY7Fb+Jjy6knr3ICh7UCPY+8CBt+5tZUOunxA4FnChz9x2hyBLDPREHd cn6Sl5UHB9+ljCfmwq0jYsVoai28kpMUSxqc9VQgvq7gDtqa9NsjW6mthdOFQcMEs7LA wmcoUf5T1YbjYu0FY5MmajHXAgz+/2s1GJARJVtC0Em47Tx0rYch5d2HO2YbATZg6KwW yPwImNVceHUYtOHIc4sXzXh3l0md/ZxB+Qfs27OyQH9+k4V5R0/iG9JFpf5trXHEJokW EMHQ== X-Forwarded-Encrypted: i=1; AJvYcCXdbGO0cF40pq3WOgEKsk8kdpzqIS4sJF/XiAVnzuXSSS2SJEdXxbN/dU4akENcNn+ow1o8S3Re0YeBNQWBFxghyDe7Zw==@freebsd.org X-Gm-Message-State: AOJu0YxojTYCScYpq/dG6YXIRMxnc/QGWTTKKqW4hXmGDiwzoJuR1dLd ZSrAx01lJvynYCrrn3rypu6ZJqvKa6LQv9T0jOJPCEZF57KT9IEFLn285DhnMIYTieCNrGVxERt d+EQwYnJA2cyKYIQNmwmOARgnltlhx4tvIXebRuIZOA== X-Gm-Gg: ASbGncuCXCQV8RznuyzsgiJNKLwDc6xG8ZHvLEtMg5RwLsm+HK8uzCvzBY0by460jL3 UddHVzqY1et55eQ4aFU/fORCb6kf9MIy/nSpl3xlO6ywloQkf2uCWksLk9PafbzPqE/IsxVw7+X mv5/UNqh5tAsT3dEr7P5/WXkXGhjAqvdF1oNgdIeCbtSVUhUZaCFHi2aR/yTbwrUb73qqJcr6lF VOexUntuArVJlLYaIsuSK9qAopCrhW/BxYPgDgb6Gc+f/S0Rg== X-Google-Smtp-Source: AGHT+IGdpG1h5OQCQDdeVupiiCOiu1spl5/V4iMKttT81PXz9akjJMIopzoMaBwi8XRmyagdcIpghjm+80IuMgRoP6c= X-Received: by 2002:a17:90b:2788:b0:329:ca48:7090 with SMTP id 98e67ed59e1d1-32d440df06fmr27278840a91.37.1757609857577; Thu, 11 Sep 2025 09:57:37 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202509111512.58BFCV87088340@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 11 Sep 2025 10:57:26 -0600 X-Gm-Features: Ac12FXx-SxD5zvNhJKSoQ7Z-wa9vCsVbuDBf2S5KrOyFSl2ilxaaLA8hEIp-pI8 Message-ID: Subject: Re: git: d20c82507278 - main - Revert "libc: Remove readdir_r(3)" To: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003702fc063e896f1f" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cN3dc0gyGz3T0r --0000000000003702fc063e896f1f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2025 at 10:27=E2=80=AFAM Olivier Cochard-Labb=C3=A9 wrote: > > On Thu, Sep 11, 2025 at 8:12=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav > wrote: > >> The branch main has been updated by des: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3Dd20c82507278e003f391c3fb04f4e4= 9afd1537ab >> >> commit d20c82507278e003f391c3fb04f4e49afd1537ab >> Author: Dag-Erling Sm=C3=B8rgrav >> AuthorDate: 2025-09-11 15:12:22 +0000 >> Commit: Dag-Erling Sm=C3=B8rgrav >> CommitDate: 2025-09-11 15:12:22 +0000 >> >> Revert "libc: Remove readdir_r(3)" >> >> This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4. >> >> > Hi Dag-Erling, > Could you please explain why this change was reversed? > Because the reason was missing from this commit message. > Rust breaks with this change. While rust can be fixed (and will be) since it's doing some sketch things and the fix is to just remove the sketch stuff. However, part of Rust's work flow is to do A/B testing between new runs under test, and older Rust versions. The old binaries work fine, but newly-built copies of the old versions do not. Until those old versions 'age out' of this setup, we'll be stuck with this. Warner --0000000000003702fc063e896f1f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Sep 11,= 2025 at 10:27=E2=80=AFAM Olivier Cochard-Labb=C3=A9 <olivier@freebsd.org> wrote:
<= div style=3D"font-family:"courier new",monospace">
On Thu, S= ep 11, 2025 at 8:12=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> wrote:
The branch main has be= en updated by des:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3Dd20c82507278e003f391c3fb04f4e49afd1537ab
commit d20c82507278e003f391c3fb04f4e49afd1537ab
Author:=C2=A0 =C2=A0 =C2=A0Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>=
AuthorDate: 2025-09-11 15:12:22 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>=
CommitDate: 2025-09-11 15:12:22 +0000

=C2=A0 =C2=A0 Revert "libc: Remove readdir_r(3)"

=C2=A0 =C2=A0 This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4.=


Hi Dag-Erling,
Could you please expl= ain why this change was reversed?
Because the reason was missing from th= is commit message.

Rust bre= aks with this change. While rust can be fixed (and will be) since it's = doing some sketch things and the fix is to just remove the sketch stuff. Ho= wever, part of Rust's work flow is to do A/B testing between new runs u= nder test, and older Rust versions. The old binaries work fine, but newly-b= uilt copies of the old versions do not. Until those old versions 'age o= ut' of this setup, we'll be stuck with this.

Warner=C2=A0
--0000000000003702fc063e896f1f--