From nobody Thu Mar 26 01:14:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fh5RS2Zyjz6X4K6 for ; Thu, 26 Mar 2026 01:15:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fh5RL6RPsz3JlM for ; Thu, 26 Mar 2026 01:14:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774487694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2OHilYDXFEedoEzBGk8oC5haDTInU+ovD4NDaRDXlx8=; b=MPr3ATkg0pHuRVwKn8uyM5hYYV+k+sBSHPuxc3S9SnRohpbGXF7Xq2DJciV4EurYLbHnE1 9Rkfx3I8fmunz9j8FQvnIRcONnLllkRKcGH4zMTdvIxdVQV8zLW1PWcgH8MAFmSEYylKHv V1/+VdmzoolIxmtJQf8SMIWzGkdpfpxp7LFmVWYM7aoKtIouI0pvku6z35FZTA8fomnuXA Yk/hdJ6zaIILSiqoaAsTkX2lvpUNK3VPfag1kMaS0CUjsffUk8/wDqHBS/wyFh0FAGYq2X YUUjPFC2XZNIVbztBp6Qb5sbAs2POP/40oyogr5RyTRTrk2+ukfAYOeaiGkYDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774487694; a=rsa-sha256; cv=none; b=hHe5j3vbuLH4qRuqHnsHviYCYmO5VT4mu166O1Xwur6YSKstdwrRoIz47nwEJDX1LZ3y8+ KMDBBW/kPPeHmeH/g1RiV6n7RUfUR1f3a94e9Jt7aqkcleHmRf226r/S/ponHrrorgHeZc SdbuzBXQF6XJ98DuRAf/w/J4BB3NV0WNN4B7To99BiXI+NFhgEiYnEWtADg/tYtUtqSws9 pKa6NmlPNDJn86F/kyIl1pxc2wPEmRdoRbL64/oT/DJpeTWU+c26M6NpAxS5NJDbvwzFlI See+ndXhOD95cxNqKkfbbni8Gyq8AA6lkt0N1I/92TLknjCqRgJ4j87SGEf4Rg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774487694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2OHilYDXFEedoEzBGk8oC5haDTInU+ovD4NDaRDXlx8=; b=Un91V/k1r2LCx1SwmWp20V/rixU5QRVA9Mx3iqKgnUHe/6YsS7kadMEqDmyyh04P1obe8m v4hA4GoOLkIIhDc3zO2r7SOf14c+3pkyoHJD/3LAxWhBYx3yv8ZI+3e7pEZhuU/OjJ/Tp2 uOkM/3d3Z0qZOtC32nHSZelo/Ia8uIQ4eHCJWK47Gi8eclcXq+llM/A3qecWqvn2/wCyhc 7ENes5OHl5sst9h8xqGWrW/CuIUiHtiirFXZdKq997U/Jhvoa1ApqSRtEgk9JA2WjyykeI AFw1m7iNZ8JcC4zLiu+ZQA5oXwazkLats6ML4V9fej0nnvkBq5pXsiHZyCodHw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fh5RL5yf3zVXg for ; Thu, 26 Mar 2026 01:14:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 472dd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 01:14:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Michael Tuexen From: Philip Paeps Subject: git: 44dd8b58394b - releng/14.4 - tcp: plug an mbuf leak List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: philip X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: 44dd8b58394b8a3bcfa68f9aba1a4a0780c85145 Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 01:14:54 +0000 Message-Id: <69c4888e.472dd.26604451@gitrepo.freebsd.org> The branch releng/14.4 has been updated by philip: URL: https://cgit.FreeBSD.org/src/commit/?id=44dd8b58394b8a3bcfa68f9aba1a4a0780c85145 commit 44dd8b58394b8a3bcfa68f9aba1a4a0780c85145 Author: Michael Tuexen AuthorDate: 2026-03-25 05:53:56 +0000 Commit: Philip Paeps CommitDate: 2026-03-25 06:53:41 +0000 tcp: plug an mbuf leak When a challenge ACK should be sent via tcp_send_challenge_ack(), but the rate limiter suppresses the sending, free the mbuf chain. The caller of tcp_send_challenge_ack() expects this similar to the callers of tcp_respond(). Approved by: so Security: FreeBSD-SA-26:06.tcp Security: CVE-2026-4247 Reviewed by: lstewart Tested by: lstewart Sponsored by: Netflix, Inc. --- sys/netinet/tcp_subr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index 81b378f496c9..32c30dc4d067 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2276,6 +2276,8 @@ tcp_send_challenge_ack(struct tcpcb *tp, struct tcphdr *th, struct mbuf *m) tcp_respond(tp, mtod(m, void *), th, m, tp->rcv_nxt, tp->snd_nxt, TH_ACK); tp->last_ack_sent = tp->rcv_nxt; + } else { + m_freem(m); } }