From owner-svn-ports-head@FreeBSD.ORG Wed Jan 16 10:26:29 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E0752E1B; Wed, 16 Jan 2013 10:26:29 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by mx1.freebsd.org (Postfix) with ESMTP id 0B959B07; Wed, 16 Jan 2013 10:26:28 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id hn14so3278282wib.4 for ; Wed, 16 Jan 2013 02:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=m2FEiBUfvqIJzB5jQhWTQ19aeMfk9f29SSvblpd8LTk=; b=aSctX8ZF/Yys+dxYt2MLJi+Bctym7dXPw9jbRO6j2otYnC2LOn/Vq5Q3VzWY8BIdzC tGoz/vKy3cSTvTcxj01Oz+KjgO9THssUbxqbRSf1uoK/Mqp6fimPgkLNwGp3fQyPpbv2 g93tHMWn5gCTW7U7xIwVTLXOorDEmp4ALFXo+ShVIJ7vj89j5WS1oX7ZQdeu0m2fkzfx xq5x2UkqMrti5iAW0A7CS5lnjC6dvZkFvgrVirww5koOKQvuzJaOgbl8ryOQkfGRNh12 obT/eZBH24iaEtm0OvkZYDDgDuGn1+xzRlc34jsOrYIgbkWfFaIxiD17hHfL8FKfHcgK qL5Q== MIME-Version: 1.0 X-Received: by 10.180.95.135 with SMTP id dk7mr8970666wib.29.1358331982012; Wed, 16 Jan 2013 02:26:22 -0800 (PST) Received: by 10.180.145.44 with HTTP; Wed, 16 Jan 2013 02:26:21 -0800 (PST) In-Reply-To: <20130116100330.GA12459@FreeBSD.org> References: <201301160817.r0G8Hrws045649@svn.freebsd.org> <20130116100330.GA12459@FreeBSD.org> Date: Wed, 16 Jan 2013 18:26:21 +0800 Message-ID: Subject: Re: svn commit: r310483 - in head/devel/tpasm: . files From: Marcelo Araujo To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: araujo@FreeBSD.org List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2013 10:26:30 -0000 2013/1/16 Alexey Dokuchaev > On Wed, Jan 16, 2013 at 08:17:53AM +0000, Marcelo Araujo wrote: > > New Revision: 310483 > > URL: http://svnweb.freebsd.org/changeset/ports/310483 > > > > Log: > > - Update to 1.8. > > - Trim header. > > I must say I see a lot of gratuitous changes that 1) do not seem to improve > anything (yet recude readability); and 2) are not mentioned in the log. > Well it depends! For me, this way has more readability. OK, does not improve nothing, but unfortunately there is no documentation saying we should follow this standard or not. In this case here, in my point of view, we can use BIKESHED. > > > PR: ports/174183 > > Submitted by: KATO Tsuguru > > Something unexpected from KATO-san. :( > I hope Kato can be more motivated and contribute much more. > > > do-install: > > - ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin > > + (cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin) > > @${MKDIR} ${PREFIX}/libdata/${PORTNAME} > > - ${INSTALL_DATA} ${WRKSRC}/include/* ${PREFIX}/libdata/${PORTNAME} > > + (cd ${WRKSRC}/include \ > > + && ${INSTALL_DATA} * ${PREFIX}/libdata/${PORTNAME}) > > .if !defined(NOPORTDOCS) > > @${MKDIR} ${DOCSDIR} > > - ${INSTALL_DATA} ${WRKSRC}/CONVERSION_C166.TXT ${WRKSRC}/MANUAL.TXT > \ > > - ${WRKSRC}/README*.TXT ${DOCSDIR} > > +.for i in CONVERSION_C166.TXT MANUAL.TXT README*.TXT > > + (cd ${WRKSRC} && ${INSTALL_DATA} ${i} ${DOCSDIR}) > > +.endfor > > .endif > > .if !defined(NOPORTEXAMPLES) > > @${MKDIR} ${EXAMPLESDIR} > > - ${INSTALL_DATA} ${WRKSRC}/samples/* ${EXAMPLESDIR} > > + (cd ${WRKSRC}/samples && ${INSTALL_DATA} * ${EXAMPLESDIR}) > > .endif > > I am referring to this particualr part of the patch. I will probably fix > it > later if I happen to touch this port again. > Go ahead, feel free to change and improve! Best Regards, -- Marcelo Araujo araujo@FreeBSD.org