From owner-svn-src-head@FreeBSD.ORG  Fri Jun  1 19:00:57 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 25B48106564A;
	Fri,  1 Jun 2012 19:00:57 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from hammer.pct.niksun.com (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E5B38FC0C;
	Fri,  1 Jun 2012 19:00:56 +0000 (UTC)
Message-ID: <4FC91168.5040002@FreeBSD.org>
Date: Fri, 01 Jun 2012 15:00:56 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120502 Thunderbird/12.0.1
MIME-Version: 1.0
To: Mitsuru IWASAKI <iwasaki@jp.freebsd.org>
References: <201206011818.q51IImh5035315@svn.freebsd.org>
	<20120602.034349.112976915.iwasaki@jp.FreeBSD.org>
In-Reply-To: <20120602.034349.112976915.iwasaki@jp.FreeBSD.org>
X-Enigmail-Version: 1.5pre
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r236414 - in head/sys: amd64/acpica i386/acpica
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2012 19:00:57 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-06-01 14:43:49 -0400, Mitsuru IWASAKI wrote:
> Hi, thanks for following up.
> 
>> Log: Call AcpiSetFirmwareWakingVector() with interrupt disabled
>> for consistency.
> 
> Are you sure about this?  Original code is like this (interrupt
> ENABLED);
> 
> ---- intr_restore(rf);
> 
> AcpiSetFirmwareWakingVector(0);
> 
> if (ret == 0 && mem_range_softc.mr_op != NULL && ----
> 
> Regarding to ACPICA source code, they said nothing about this so I
> think it's not big deal.
> 
> Just FYI, AcpiSetFirmwareWakingVector(0) was called with interrupt 
> enabled in Linux.

This function does not care about interrupt context.  However, the
first AcpiSetFirmwareWakingVector() is now called with interrupt
disabled after r236403.  Thus, I wanted it to be consistent as well.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/JEWgACgkQmlay1b9qnVN+zwCfTn5zY6gmmAipPnsIgvjEK6vC
5k4AoMjdIUmRg5EuR0awEG4+uiqGCAWo
=ZYNR
-----END PGP SIGNATURE-----