From nobody Wed May 24 22:14:06 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QRQT64Hq5z4V4XV for ; Wed, 24 May 2023 22:14:18 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QRQT430v4z3K8y for ; Wed, 24 May 2023 22:14:15 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of junchoon@dec.sakura.ne.jp has no SPF policy when checking 153.125.133.21) smtp.mailfrom=junchoon@dec.sakura.ne.jp; dmarc=none Received: from kalamity.joker.local (123-1-88-210.area1b.commufa.jp [123.1.88.210]) (authenticated bits=0) by www121.sakura.ne.jp (8.16.1/8.16.1/[SAKURA-WEB]/20201212) with ESMTPA id 34OME6Yu005601; Thu, 25 May 2023 07:14:06 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Thu, 25 May 2023 07:14:06 +0900 From: Tomoaki AOKI To: dev-commits-src-main@freebsd.org Cc: Randall Stewart Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Message-Id: <20230525071406.c5ea33f08fd27adb0c39f158@dec.sakura.ne.jp> In-Reply-To: <1E5C3216-1A6F-43AC-AA91-24FA1EA18842@netflix.com> References: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp> <1E5C3216-1A6F-43AC-AA91-24FA1EA18842@netflix.com> Reply-To: junchoon@dec.sakura.ne.jp Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.2) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-0.83 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-0.99)[-0.988]; MV_CASE(0.50)[]; NEURAL_HAM_SHORT(-0.25)[-0.252]; MIME_GOOD(-0.10)[text/plain]; HAS_GOOGLE_REDIR(0.01)[]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[sakura.ne.jp]; HAS_REPLYTO(0.00)[junchoon@dec.sakura.ne.jp]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; HAS_ORG_HEADER(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4QRQT430v4z3K8y X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N On Tue, 23 May 2023 09:59:33 -0400 Randall Stewart wrote: > > https://reviews.freebsd.org/D40229 > > Should fix this :) > > R > > On May 21, 2023, at 6:06 PM, Tomoaki AOKI wrote: > > > >> On Tue, Apr 4, 2023 at 12:31 PM Randall Stewart wrote: > >>> > >>> The branch main has been updated by rrs: > >>> > >>> URL: https://www.google.com/url?q=https://cgit.FreeBSD.org/src/commit/?id%3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=gmail-imap&ust=1685311614000000&usg=AOvVaw0HmtU6ylNo8jRrPgvtzIB0 > >>> > >>> commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f > >>> Author: Randall Stewart > >>> AuthorDate: 2023-04-01 05:46:38 +0000 > >>> Commit: Randall Stewart > >>> CommitDate: 2023-04-01 05:46:38 +0000 > >>> > >>> Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. > >>> > >>> So stack switching as always been a bit of a issue. We currently use a break before make setup which means that > >>> if something goes wrong you have to try to get back to a stack. This patch among a lot of other things changes that so > >>> that it is a make before break. We also expand some of the function blocks in prep for new features in rack that will allow > >>> more controlled pacing. We also add other abilities such as the pathway for a stack to query a previous stack to acquire from > >>> it critical state information so things in flight don't get dropped or mis-handled when switching stacks. We also add the > >>> concept of a timer granularity. This allows an alternate stack to change from the old ticks granularity to microseconds and > >>> of course this even gives us a pathway to go to nanosecond timekeeping if we need to (something for the data center to consider > >>> for sure). > >>> > >>> Once all this lands I will then update rack to begin using all these new features. > >>> > >>> Reviewed by: tuexen > >>> Sponsored by: Netflix Inc > >>> Differential Revision: https://www.google.com/url?q=https://reviews.freebsd.org/D39210&source=gmail-imap&ust=1685311614000000&usg=AOvVaw1ZouYiMywAnpdYyYCp9T9O > >> > >> Hi, > >> > >> Could you hide some stuff in netinet/tcp.h? > >> struct http_req breaks curl 8.1.0. > >> > >> Antoine > > > > Please refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan > > Reynolds. > > A patch is proposed there inline (not as an attachment). > > > > [1] https://www.google.com/url?q=https://bugs.freebsd.org/bugzilla/show_bug.cgi?id%3D271526&source=gmail-imap&ust=1685311614000000&usg=AOvVaw2e-0D0bz7CAIVj6kvLZOJg > > > > [2] https://www.google.com/url?q=https://bugs.freebsd.org/bugzilla/show_bug.cgi?id%3D271526%23c4&source=gmail-imap&ust=1685311614000000&usg=AOvVaw154j12MkBXKn2z9_gepR1n > > > > -- > > Tomoaki AOKI > > ------ > Randall Stewart > rrs@netflix.com Thanks! ftp/curl 8.1 built fine with your diff. What's done: Back out the patch at Bug 271526 Apply your diff at D40229 Forcibly rebuild/reinstall base as usual and reboot Forcibly rebuild ftp/curl, which is still before 8.1.1 base is at commit 902dc544cc5859e24c727126e45416133c1c6d46, amd64. Regards. -- Tomoaki AOKI