Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Feb 2003 22:54:04 +0900 (JST)
From:      Munehiro Matsuda <haro@h4.dion.ne.jp>
To:        glewis@eyesbeyond.com
Cc:        freebsd-java@freebsd.org
Subject:   Re: [REPOST] java/47397: [PATCH] java/jdk13 to enable HotSpot
Message-ID:  <20030225.225404.74756090.haro@h4.dion.ne.jp>
In-Reply-To: <20030225154141.A48569@misty.eyesbeyond.com>
References:  <15962.16668.753657.116140@ool-18bacefa.dyn.optonline.net> <20030225.014627.41626713.haro@h4.dion.ne.jp> <20030225154141.A48569@misty.eyesbeyond.com>

next in thread | previous in thread | raw e-mail | index | archive | help
----Next_Part(Tue_Feb_25_22:54:04_2003_708)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hello Greg, 

Thanks for integrating my patch.

From: Greg Lewis <glewis@eyesbeyond.com>
Date: Tue, 25 Feb 2003 15:41:41 +1030
::Can people please look over the attached patch in terms of enabling HotSpot
::for the jdk13 port.  This is based on Munehiro Matsuda-san's excellent
::patch with some small modifications.  The main changes I've made are:
::
::. Simplify the HotSpot VM selection.  We just build them all and install
::  them appropriately (the result is as per the linux-sun-jdk13 port).
::. Use ${REINPLACE_COMMAND} rather than extra patches to change the gcc
::  usage for the port.
::
::This is how I'd prefer to do things at least initially.

These approaches are better than mine. :-)

::I'd really appreciate it if a few people (other than me :) would test
::these.  My main concern is if Matsuda-san's patches worked for you and
::these fail then I definitely want to know.

Found three problems with the patch.
  1) Patch for patch-threads_md.c were currpted, i.e. '^M' missing.
     I think you need to resend patch with gzip+uuencode.

  2) HOTSPOT_TARGETS is being set in the wrong place, 5-current would
     fail to build.

  3) A Change request (Patch not tested)
     For NODEBUG case, don't wast time building debug version.

Thanks,
  Haro
=------------------------------------------------------------------------------
           _ _    Munehiro (haro) Matsuda
 -|- /_\  |_|_|   Business Incubation Dept., Kubota Corp.
 /|\ |_|  |_|_|   1-3 Nihonbashi-Muromachi 3-Chome
                  Chuo-ku Tokyo 103-8310, Japan
                  Tel: +81-3-3245-3318  Fax: +81-3-3245-3315
                  Email: haro@kgt.co.jp


----Next_Part(Tue_Feb_25_22:54:04_2003_708)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="new_hotspot.patch"

--- Makefile.org	Tue Feb 25 20:13:13 2003
+++ Makefile	Tue Feb 25 22:05:58 2003
@@ -118,6 +118,10 @@
 HOTSPOT_BUILD=	../ext/plugin/build/solaris/GNUmakefile \
 	../../hotspot1.3.1/build/linux/makefiles/adlc.make \
 	../../hotspot1.3.1/build/linux/platform_i486
+.endif
+.if defined(NODEBUG)
+HOTSPOT_TARGETS=product1 product
+.else
 HOTSPOT_TARGETS=compiler1 compiler2
 .endif
 

----Next_Part(Tue_Feb_25_22:54:04_2003_708)----

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-java" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030225.225404.74756090.haro>