Date: Thu, 8 Apr 2010 09:16:25 GMT From: Pavel Plesov <pavel.plesov@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/145511: [patch] x11/gnome-terminal - patch typo Message-ID: <201004080916.o389GPEQ076026@www.freebsd.org> Resent-Message-ID: <201004080920.o389K55u093218@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 145511
>Category: ports
>Synopsis: [patch] x11/gnome-terminal - patch typo
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Thu Apr 08 09:20:05 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Pavel Plesov
>Release: FreeBSD 8.0-STABLE
>Organization:
>Environment:
FreeBSD 8.0-STABLE #5: Fri Mar 26 14:08:29 MSK 2010 amd64
>Description:
Revision 1.7 of patch-src_terminal-screen.c.diff have a typo: it uses not-initialized variable fgpid and fails to get cwd every time.
According to original gnome-terminal code changes it should contains value of "pid" argument of cwd_of_pid().
Please find the patch attached.
>How-To-Repeat:
Try to open new tab - working directory will != working directory of previously active tab.
>Fix:
Patch attached with submission follows:
--- /usr/ports/x11/gnome-terminal/files/patch-src_terminal-screen.c.orig 2010-04-08 13:02:04.730601283 +0400
+++ /usr/ports/x11/gnome-terminal/files/patch-src_terminal-screen.c 2010-04-08 13:03:23.932009283 +0400
@@ -50,7 +50,7 @@
}
}
+#else
-+ int fgpid;
++ int fgpid = pid;
+#if __FreeBSD_version > 800018 || (__FreeBSD_version < 800000 && __FreeBSD_version >= 700104)
+#ifndef HAVE_KINFO_GETFILE
+ name[0] = CTL_KERN;
--- /usr/ports/x11/gnome-terminal/Makefile.orig 2010-04-08 13:05:00.639450034 +0400
+++ /usr/ports/x11/gnome-terminal/Makefile 2010-04-08 13:04:27.052025096 +0400
@@ -8,7 +8,7 @@
PORTNAME= gnome-terminal
PORTVERSION= 2.28.2
-PORTREVISION= 2
+PORTREVISION= 3
CATEGORIES= x11 gnome
MASTER_SITES= GNOME
DIST_SUBDIR= gnome2
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004080916.o389GPEQ076026>