Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Sep 2022 05:07:23 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 7d0e83c60bed - main - arm: add dwc3/xhci as build options for ARM
Message-ID:  <242CC11F-A906-4B03-B3BF-EAC2677B6A8E@freebsd.org>
In-Reply-To: <28B3D50F-6699-4BCE-A6C6-3BEC4785EB6F@freebsd.org>
References:  <202209120236.28C2arB7033900@gitrepo.freebsd.org> <28B3D50F-6699-4BCE-A6C6-3BEC4785EB6F@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12 Sept 2022, at 04:53, Jessica Clarke <jrtc27@FreeBSD.org> wrote:
>=20
> On 12 Sept 2022, at 03:36, Adrian Chadd <adrian@FreeBSD.org> wrote:
>>=20
>> The branch main has been updated by adrian:
>>=20
>> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D7d0e83c60bedf601e61d80187cdfa785=
fa4b1963
>>=20
>> commit 7d0e83c60bedf601e61d80187cdfa785fa4b1963
>> Author:     Adrian Chadd <adrian@FreeBSD.org>
>> AuthorDate: 2022-09-11 23:57:52 +0000
>> Commit:     Adrian Chadd <adrian@FreeBSD.org>
>> CommitDate: 2022-09-12 02:36:42 +0000
>>=20
>>   arm: add dwc3/xhci as build options for ARM
>=20
> dwc3 already was there?

Also, xhci already exists for arm and pulls in the generic PCI-based
XHCI driver in sys/conf/files. What you really mean is that you added
generic_xhci(_fdt) to arm kernels as needed by dwc3.

Jess

>>   Summary:
>>   This mirrors the recentish changes to armv8; the ipq4018 port uses
>>   dwc3 + xhci and thus needs this.
>>=20
>>   Subscribers: imp, andrew
>>=20
>>   Reviewed by: imp
>>=20
>>   Differential Revision: https://reviews.freebsd.org/D36530
>=20
> This is not the right format for commit messages.
>=20
> Jess
>=20
>> ---
>> sys/conf/files.arm | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>=20
>> diff --git a/sys/conf/files.arm b/sys/conf/files.arm
>> index 85afa4893d3c..c7e8a52a813d 100644
>> --- a/sys/conf/files.arm
>> +++ b/sys/conf/files.arm
>> @@ -99,7 +99,10 @@ dev/psci/psci.c			optional	=
psci
>> dev/psci/smccc_arm.S		optional	psci
>> dev/syscons/scgfbrndr.c		optional	sc
>> dev/uart/uart_cpu_fdt.c		optional	uart fdt
>> -dev/usb/controller/dwc3.c	optional	fdt dwc3
>> +
>> +dev/usb/controller/dwc3.c		optional	fdt dwc3
>> +dev/usb/controller/generic_xhci.c	optional	xhci
>> +dev/usb/controller/generic_xhci_fdt.c	optional	xhci fdt
>>=20
>> kern/msi_if.m			optional	intrng
>> kern/pic_if.m			optional	intrng
>=20




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?242CC11F-A906-4B03-B3BF-EAC2677B6A8E>