From owner-svn-src-head@FreeBSD.ORG Wed Jan 28 20:41:24 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F135106589E; Wed, 28 Jan 2009 20:41:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 28AE48FC1F; Wed, 28 Jan 2009 20:41:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id C976246B65; Wed, 28 Jan 2009 15:41:23 -0500 (EST) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n0SKekcl099624; Wed, 28 Jan 2009 15:41:18 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kostik Belousov Date: Wed, 28 Jan 2009 15:33:05 -0500 User-Agent: KMail/1.9.7 References: <200901281854.n0SIsvNX029332@svn.freebsd.org> <20090128203053.GJ2009@deviant.kiev.zoral.com.ua> In-Reply-To: <20090128203053.GJ2009@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901281533.06173.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 28 Jan 2009 15:41:18 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8914/Wed Jan 28 01:40:00 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187838 - head/sys/fs/cd9660 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 20:41:26 -0000 On Wednesday 28 January 2009 3:30:55 pm Kostik Belousov wrote: > On Wed, Jan 28, 2009 at 06:54:57PM +0000, John Baldwin wrote: > > Author: jhb > > Date: Wed Jan 28 18:54:56 2009 > > New Revision: 187838 > > URL: http://svn.freebsd.org/changeset/base/187838 > ... > > - Use an inlined version of vn_vget_ino() to handle races with .. > > lookups. I had to inline the code here since cd9660 uses an internal > > vget routine to save a disk I/O that would otherwise re-read the > > directory block. > > Hmm, also please see the ffs_softdep.c:softdep_fsync(), that also > needs the similar fix and cannot be converted to vn_vget_ino() due to > ffs_vgetf(). > > I was unable to propose some useful generalization of vn_vget_ino() > so far. Maybe it would be possible to have subroutines for the before and after bits that go around the vget() (That could be ugly though)? For my udf patches I was able to use vn_vget_ino() which was nice. -- John Baldwin