From owner-freebsd-doc@FreeBSD.ORG  Thu Mar 17 00:25:23 2005
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
Delivered-To: freebsd-doc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AEB2816A4CE
	for <freebsd-doc@freebsd.org>; Thu, 17 Mar 2005 00:25:23 +0000 (GMT)
Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AE76343D39
	for <freebsd-doc@freebsd.org>; Thu, 17 Mar 2005 00:25:22 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from gothmog.gr (patr530-b174.otenet.gr [212.205.244.182])
	j2H0OuSa009958
	for <freebsd-doc@freebsd.org>; Thu, 17 Mar 2005 02:24:56 +0200
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.13.3/8.13.3) with ESMTP id j2FMr7Rm079017;
	Wed, 16 Mar 2005 00:53:07 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from giorgos@localhost)
	by gothmog.gr (8.13.3/8.13.3/Submit) id j2FMr7jc079009;
	Wed, 16 Mar 2005 00:53:07 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Wed, 16 Mar 2005 00:53:07 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: Max Laier <max@love2party.net>
Message-ID: <20050315225307.GA63327@gothmog.gr>
References: <200503152143.20393.max@love2party.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503152143.20393.max@love2party.net>
cc: freebsd-doc@freebsd.org
Subject: Re: [firewalls] Notes about pf as a module
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Mar 2005 00:25:23 -0000

On 2005-03-15 21:43, Max Laier <max@love2party.net> wrote:
> as per a discussion on -stable and a IPF related PR (kern/70401) - I'd
> like to add a note about this problem in the PF documentation.  See
> attachted diff for details.  IPF (and IPFW???) might need similar, but
> that's not my field of expertise ;)

> +
> +      <note>
> +	<para>The module assumes the presence of <literal>options
> +	  INET</literal> and <literal>device bpf</literal>.  Unless
> +	  <literal>NOINET6</literal> (for example in &man.make.conf.5;) was
> +	  defined during the build, it also requires <literal>options
> +	  INET6</literal>.</para>
> +      </note>

I think the NO_XXX options are spelled consistently with an underscore
these days.

Other than that, the change looks fine here.  I usually do have a
preference for quoting literal text in separate paragraphs, as in:

%     <note>
%       <para>The module assumes the presence of at least the following
%         options in the kernel configuration file:</para>
%
%       <programlisting>options            INET
% device           bpf</programlisting>
%
%       <para>Unless <literal>NOINET6</literal> (for example in
%         &man.make.conf.5;) was defined during the build, it also
%         requires:</para>
%
%       <programlisting>options            INET6</programlisting>
%     </note>

But that's just a matter of personal taste.