From owner-freebsd-current@FreeBSD.ORG Sat Jul 7 13:14:01 2007 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AC66516A46D; Sat, 7 Jul 2007 13:14:01 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 2219613C4BD; Sat, 7 Jul 2007 13:14:00 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l67DDxlb097285; Sat, 7 Jul 2007 17:13:59 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru; s=default; t=1183814040; bh=hH/FlltudC+goDHEaYrLGc5gTykAvhCEdyLPulz uDNw=; l=853; h=Received:Date:From:To:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=jO17F9jlh0A/kHD86g37 ExLVCwg35d6b8P/2DdLP4nnuWSYCccb9gJbg4xi/WL4V2KusOQ4+L2DJWeVHqolotWg qquf7UzyCevW8Akn/jrRJyVv2kFYzmRiT/rgXS1A7SBUQvfLl0Ej+K6j90E6Ib4C5dN 5RnwAMD5dtBfzNxWE= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l67DDxqo097284; Sat, 7 Jul 2007 17:13:59 +0400 (MSD) (envelope-from ache) Date: Sat, 7 Jul 2007 17:13:59 +0400 From: Andrey Chernov To: "Sean C. Farley" , Robert Watson , freebsd-current , Michal Mertl Message-ID: <20070707131359.GB96605@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "Sean C. Farley" , Robert Watson , freebsd-current , Michal Mertl References: <20070704173905.T67251@fledge.watson.org> <20070704121316.A77978@thor.farley.org> <20070704180000.GA34042@nagual.pp.ru> <20070704144159.X77978@thor.farley.org> <20070704195939.GA35302@nagual.pp.ru> <20070704235630.GA42227@nagual.pp.ru> <20070704215154.O77978@thor.farley.org> <20070705115816.GA50506@nagual.pp.ru> <20070705105922.F98700@thor.farley.org> <20070707130859.GA96605@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070707130859.GA96605@nagual.pp.ru> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2007 13:14:01 -0000 On Sat, Jul 07, 2007 at 05:09:00PM +0400, Andrey Chernov wrote: > Well, I see. You try to keep envVars[] between environ switch by that way. > > But it still look complicated and probably gains nothing. I.e. will be > much _faster_ just free envVars[] (but not variables themselfs) and allow > build_env() to calloc() new array for envVars and fills it from new > environ. It is surely faster than calling setenv() for each variable just > for sake of keepeng once allocated envVars[]. > > Moreover, environ switch commonly used to switch from large environ to > smaller one (or to empty one), so the rest of old envVars[] array would > keep unneccessary allocation. BTW, if you just free(envVars) when environ switch is detected, there is no needs to __remove_putenv() (big slowdown) in the __clean_env() too. -- http://ache.pp.ru/