From owner-svn-src-all@freebsd.org Tue Feb 21 01:35:15 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E28FACE7871; Tue, 21 Feb 2017 01:35:15 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76A44672; Tue, 21 Feb 2017 01:35:15 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x229.google.com with SMTP id c85so96001123wmi.1; Mon, 20 Feb 2017 17:35:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s3LSJZYbIvPD+Tuz3cHSkIg4stv7oxSaT+djl6L2r7E=; b=dCPn16Kna7UhYInibC3YdlqsLRtBlzFxCBHfGSN5016mjqPosLIPXj0io1QSh+FJDi jDRH9enkkB1Zqd/XPgzdcagjJCDe49fZUlor5ETruiMZzFm5WgCOkeb5zCkWllyM0ghy OtpS8jVe35oK6Gd/pbv8aEqtfng2KbfCy3MYuRMLMAIdIPYIQG1BewH6SdwUVvil9PIT Y7PbttAE0gy/XXLGSMcCPB3VMS6mxs/xE9Rybj1s2ZMWLNVXXqRg9Icm3YQyKUEo24LE gea94tRIa+vfQmU4an5fywJ+PVGF01F/CH0WFw53Pp2MTeZLZWhqiVPL7/FwSy5V9feA cVhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=s3LSJZYbIvPD+Tuz3cHSkIg4stv7oxSaT+djl6L2r7E=; b=adi1s/QCexYv5JoK7RUYxvoy4nteEizgH+nsSxesD8W2e4JSfsUpFJZ0gf7Iw+zPBg 0TlWg4d4aGLoY9mX7Mhabfa3UctjtROx2Jttb4irrxad1Cd54lHpRjdFWLfWAeppf6Jf Jp0L3PFwZOpgVMzuq0t7jeyjUPrvEa13YnZW0q8wAASBi7OPlReq8Vuj6KCf79MpLbFm BlQR50EXz8feB5XPbNgi5YN8Xp+oBpioFmYKZ0lJ/xkICGB3LqYSacymhHeTSwGFy329 JFpZTlElNdaG4+a8N8IkaM5DvwQRiKWEOzkHiztLL8Oj/N4VrW6Y2fO8JmJrq3z2yeMQ l9Tw== X-Gm-Message-State: AMke39lrb2Egq2uuFkSjQ61boRT09SA2lkh+rtx6rAyT5zpsZhfd1fNnbRyhcAanCMLQbg== X-Received: by 10.28.61.84 with SMTP id k81mr21303173wma.27.1487640913840; Mon, 20 Feb 2017 17:35:13 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id d29sm15622621wmi.19.2017.02.20.17.35.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 20 Feb 2017 17:35:12 -0800 (PST) Date: Tue, 21 Feb 2017 02:35:10 +0100 From: Mateusz Guzik To: Bruce Evans Cc: Hans Petter Selasky , Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313859 - in head/sys: kern sys Message-ID: <20170221013510.GF26759@dft-labs.eu> References: <201702170645.v1H6j4l6060548@repo.freebsd.org> <2c01557a-3412-8b46-ef4d-77214566b74a@selasky.org> <20170217203028.K2144@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170217203028.K2144@besplex.bde.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 01:35:16 -0000 On Fri, Feb 17, 2017 at 09:15:00PM +1100, Bruce Evans wrote: > On Fri, 17 Feb 2017, Hans Petter Selasky wrote: > > >>Log: > >> Introduce SCHEDULER_STOPPED_TD for use when the thread pointer > >>was already read > >> > >> Sprinkle in few places. > >> > >>Modified: > >> head/sys/kern/kern_condvar.c > >> head/sys/kern/kern_synch.c > >> head/sys/sys/systm.h > > > >Do these checks also cover panics? Or only shutdown? > > This is just an optimization. > > I don't like it because it moves further from moving the stopped flag > back out of the thread to a global. > I only did this to make it more feasible to remove the tid argument from primitives which I may or may not end up doing, undecided yet. As for changing the conditon to testing a global, I don't think this change affects feasibilitly. It onlly requires some more churn by hand which I'm happy to do if said change is implemented. -- Mateusz Guzik