From owner-svn-ports-all@freebsd.org Mon Apr 22 17:52:05 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DCAF15A0535; Mon, 22 Apr 2019 17:52:05 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44D0E6F17F; Mon, 22 Apr 2019 17:52:05 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 354FE13828; Mon, 22 Apr 2019 17:52:05 +0000 (UTC) From: Jan Beich To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r499648 - head/archivers/libcabinet/files In-Reply-To: <201904221434.x3MEYFBw046839@repo.freebsd.org> (Tobias Kortkamp's message of "Mon, 22 Apr 2019 14:34:15 +0000 (UTC)") References: <201904221434.x3MEYFBw046839@repo.freebsd.org> Date: Mon, 22 Apr 2019 19:51:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 44D0E6F17F X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.95)[-0.948,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 17:52:05 -0000 Tobias Kortkamp writes: > Author: tobik > Date: Mon Apr 22 14:34:15 2019 > New Revision: 499648 > URL: https://svnweb.freebsd.org/changeset/ports/499648 > > Log: > archivers/libcabinet: Unbreak build on recent CURRENT > > c++ -O2 -pipe -fstack-protector -fno-strict-aliasing -Wno-deprecated -std=c++11 -Wno-c++11-extensions -c bstring.cpp -o bstring.o > In file included from bstring.cpp:16: > ./bstring.h:59:40: error: use of undeclared identifier 'strlwr'; did you mean 'strlen'? > b_string& StrLwr() { if(str != NULL) strlwr(str); return *this; } > ^~~~~~ > strlen > > http://beefy12.nyi.freebsd.org/data/head-amd64-default/p499421_s346424/logs/errors/libcabinet-0.30_2.log > > This is caused by having a CXXSTD with default value of c++11 in > bsd.sys.mk now. Set CXXSTD to gnu++98 explicitly. CXXSTD is nop on FreeBSD < 13 but Clang >= 6 defaults to C++14. The actual issue here is not C++ standard version but GNU extensions. See also https://reviews.freebsd.org/D19895 created my report in https://lists.freebsd.org/pipermail/svn-src-head/2019-April/123993.html