Date: Mon, 11 Aug 2014 07:50:40 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Marcus von Appen <mva@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke... Message-ID: <1541578.rWvlqK3ZQn@mercury.ph.man.ac.uk> In-Reply-To: <20140810164416.GA43983@FreeBSD.org> References: <53e7336d.2c4d.2257f090@svn.freebsd.org> <2556564.WKGpsAPjlp@mercury.ph.man.ac.uk> <20140810164416.GA43983@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 10 Aug 2014 16:44:16 +0000 Alexey Dokuchaev wrote: > On Sun, Aug 10, 2014 at 03:40:11PM +0000, Max Brazhnikov wrote: > > On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote: > > > On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote: > > > > New Revision: 364518 > > > > URL: http://svnweb.freebsd.org/changeset/ports/364518 > > > > QAT: https://qat.redports.org/buildarchive/r364518/ > > > > > > > > -USES= pkgconfig > > > > +USES= pkgconfig python:2 > > > > USE_GNOME= atk > > > > -USE_PYTHON= 2 > > > > -USE_PYDISTUTILS=yes > > > > -PYDISTUTILS_AUTOPLIST= yes > > > > +PYTHON_FEATURES=autoplist distutils > > > > > > Yuck, this PYTHON_FEATURES knob is ugly. Why not follow Perl's example > > > instead (USES=perl and USE_PERL)? It both makes more sense and shorter. > > > > ugly or not, it's a matter of taste. [...] > > Not really. It is also 1) inconsistent with USE_PERL, and 2) is overly > long knob name (breaks indentation). 1) I don't think USE_PERL is worthy of comparison, USE_XXX shouldn't be used after conversion to USES: - it complicates the transition - it's inconsistent with other old style USE_YXZ I'd like to see something like XXX_COMPONENTS for this, but it is too long :) 2) I'd prefer broken indentation to clear meaning. > ../danfe > > P.S. I'm wondering about these "a matter of taste" reasons. Are you > guys really don't see the ugliness when it's there? Why defending it > when it can/should be just fixed? I don't defend it. I just dislike it for different reasons than you :) Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1541578.rWvlqK3ZQn>