From owner-freebsd-ports@freebsd.org Sun Dec 10 21:41:09 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05C33E9DB41 for ; Sun, 10 Dec 2017 21:41:09 +0000 (UTC) (envelope-from se@freebsd.org) Received: from mailout07.t-online.de (mailout07.t-online.de [194.25.134.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout00.t-online.de", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B925564359 for ; Sun, 10 Dec 2017 21:41:08 +0000 (UTC) (envelope-from se@freebsd.org) Received: from fwd34.aul.t-online.de (fwd34.aul.t-online.de [172.20.26.145]) by mailout07.t-online.de (Postfix) with SMTP id 5EAF742C057B; Sun, 10 Dec 2017 22:33:26 +0100 (CET) Received: from Stefans-MBP-2.fritz.box (GW8TFrZLYhebH0bkDfDXDTMGG+SlIGm+UmWBLY-2T1dYxzYZgsRyM6RU+k4ZCopQfH@[87.151.220.147]) by fwd34.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1eO9Dy-189OZE0; Sun, 10 Dec 2017 22:33:26 +0100 Subject: Re: Working on FLAVOR support in portmaster To: Matthieu Volat , Chris H Cc: freebsd-ports@freebsd.org References: <20171209102517.005de250@gramr.alkumuna.eu> <17c98bad038d40d023c8e1e3f93fe160@udns.ultimatedns.net> <20171210184716.604de089@gramr.alkumuna.eu> From: Stefan Esser Message-ID: Date: Sun, 10 Dec 2017 22:33:25 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171210184716.604de089@gramr.alkumuna.eu> Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-ID: GW8TFrZLYhebH0bkDfDXDTMGG+SlIGm+UmWBLY-2T1dYxzYZgsRyM6RU+k4ZCopQfH X-TOI-MSGID: a12e8f78-00d3-440b-8eee-c132ee79eb40 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Dec 2017 21:41:09 -0000 Am 10.12.17 um 18:47 schrieb Matthieu Volat: > They do... but only if you commit and push something (even if it's only > a personnal clone). If you just keep the changes on your computer, there's > nothing. The GitHub master version has changes, that are not yet in any release. This is irrelevant as long as FLAVOR support is missing in portmaster, since there is no version that fully supports flavors, right now. > As much as I am defiant of github on certain aspects, I've found in quite > some occasion the discussion/comment system around pull requests quite nice. I'm working in FLAVOR support and I have a version that correctly builds the Python ports, that have been converted. But I'm currently trying to understand, where the information that the ports is to be re-installed, gets lost. Debugging shell scripts is a lot of work, since you cannot single step through them. Portmaster does call itself recursively, which further complicates understanding and tracing the execution. (Besides, portmaster is a main program of 4300+ lines with functions sprinkled throughout the code. I have a local version, which breaks this large main program in named subroutines, which makes it much easier to understand the logic flow, but hides the actual changes when creating diffs. I have backported the FLAVOR changes to a portmaster version without those subroutines, to get the minimal functional patch, but now I'm fighting with the install vs. upgrade distinction being lost.) I can send you the current version in private mail (I do not want to spam the mail-list with a 120k+ shell script). Regards, STefan