From owner-svn-ports-head@freebsd.org  Tue May  8 05:33:34 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09A9FFCF48E;
 Tue,  8 May 2018 05:33:34 +0000 (UTC)
 (envelope-from tobik@FreeBSD.org)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A6DD468E02;
 Tue,  8 May 2018 05:33:33 +0000 (UTC)
 (envelope-from tobik@FreeBSD.org)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 8EF4E21BE7;
 Tue,  8 May 2018 01:33:32 -0400 (EDT)
Received: from web6 ([10.202.2.216])
 by compute4.internal (MEProxy); Tue, 08 May 2018 01:33:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EGpbfM
 g5YAeqGr2VzFuFnfEToIqfO3guOl0wjmhAxwk=; b=Y+LpG36Xvt67lAuiPE2izI
 2VLvgT4ncL5vbrrPISfr132sZYWXDoDK/jXQOlNjGjCnB5TuTIgsUaBIRp/TGPsK
 submwLvoQn82Jd/CpFjwx+sQa92m58VKPv3hcIxUShOZfuso57k5gaORLBL11hcg
 EpZl6EATHr0Gk3R2cHZ5eDkd3KYAteweVTMphQI4hXcKhft7KmJ0RSM+oi8IflOa
 dSx47KxZryRNTNwTwEi/tqrLDQFhmz7f94JHI8SgGjWpMlW1iT+CaysJ7xobSjMi
 yXwYrmgt5iUCdplakCcvU/YWn7nCGkxKUKeZhAJ5ppIihD6XO05AQjz8RUPLmvgQ
 ==
X-ME-Sender: <xms:rDbxWsV8yTe586O4cxJ2EJbiteK_aPboSnciiXkEm82Fy3sLeI0jtw>
Received: by mailuser.nyi.internal (Postfix, from userid 99)
 id 386D44284; Tue,  8 May 2018 01:33:32 -0400 (EDT)
Message-Id: <1525757612.2026906.1364357368.6FA88FAC@webmail.messagingengine.com>
From: Tobias Kortkamp <tobik@FreeBSD.org>
To: Yuri Victorovich <yuri@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-62b61488
Date: Tue, 08 May 2018 07:33:32 +0200
References: <201805080519.w485J3mn074557@repo.freebsd.org>
In-Reply-To: <201805080519.w485J3mn074557@repo.freebsd.org>
Subject: Re: svn commit: r469355 - head/sysutils/UEFITool
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 May 2018 05:33:34 -0000

On Tue, May 8, 2018, at 07:19, Yuri Victorovich wrote:
> Author: yuri
> Date: Tue May  8 05:19:03 2018
> New Revision: 469355
> URL: https://svnweb.freebsd.org/changeset/ports/469355
> 
> Log:
>   sysutils/UEFITool: Update 45 -> 49
>   
>   Port changes:
>   * Change to DISTVERSION
>   * Add LICENSE_FILE
>   * Order USExx section
>   * Other small ordering changes
>   * Silence the stripping command
>   
>   PR:		228040
>   Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl> (maintainer; only a 
> version change)
> 
> Modified:
>   head/sysutils/UEFITool/Makefile
>   head/sysutils/UEFITool/distinfo
> 
> Modified: head/sysutils/UEFITool/Makefile
> ==============================================================================
> --- head/sysutils/UEFITool/Makefile	Tue May  8 05:07:47 2018	(r469354)
> +++ head/sysutils/UEFITool/Makefile	Tue May  8 05:19:03 2018	(r469355)
> @@ -2,28 +2,28 @@
>  # $FreeBSD$
>  
>  PORTNAME=	UEFITool
> -PORTVERSION=	45
>  DISTVERSIONPREFIX=	A
> +DISTVERSION=	49
>  CATEGORIES=	sysutils
>  
>  MAINTAINER=	pkubaj@anongoth.pl
>  COMMENT=	UEFI images parser
>  
>  LICENSE=	MIT
> +LICENSE_FILE=	${WRKSRC}/../LICENSE.md
>  
> +USES=		qmake:outsource
>  USE_GITHUB=	yes
>  GH_ACCOUNT=	LongSoft
> +USE_GL=		gl
> +USE_QT5=	core gui widgets buildtools_build qmake_build
>  
> -WRKSRC_SUBDIR=		${PORTNAME}
> +WRKSRC_SUBDIR=	${PORTNAME}
>  
>  PLIST_FILES=	bin/${PORTNAME}
>  
> -USES=		qmake:outsource
> -USE_GL=		gl
> -USE_QT5=	buildtools_build core gui widgets qmake_build
> -
>  pre-install:
> -	${STRIP_CMD} ${WRKDIR}/.build/${PORTNAME}
> +	@${STRIP_CMD} ${WRKDIR}/.build/${PORTNAME}
>  
>  do-install:
>  	${INSTALL_PROGRAM} ${WRKDIR}/.build/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

What's the point of STRIP_CMD followed by INSTALL_PROGRAM
(which will strip the binary as well)?  I think pre-install can be completely
dropped.