From owner-svn-src-head@freebsd.org Sun Mar 29 19:46:27 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E0B4260A8E; Sun, 29 Mar 2020 19:46:27 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48r5gY3KZ9z4Glv; Sun, 29 Mar 2020 19:46:17 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id A06D03C0199; Sun, 29 Mar 2020 19:46:07 +0000 (UTC) Date: Sun, 29 Mar 2020 19:46:07 +0000 From: Brooks Davis To: Enji Cooper Cc: Enji Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359385 - head/usr.bin/kyua Message-ID: <20200329194607.GB40889@spindle.one-eyed-alien.net> References: <202003280108.02S18KWc062782@repo.freebsd.org> <20200328032209.GA40889@spindle.one-eyed-alien.net> <2A7EAECB-C11A-458C-9495-BC975300D363@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK" Content-Disposition: inline In-Reply-To: <2A7EAECB-C11A-458C-9495-BC975300D363@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 48r5gY3KZ9z4Glv X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-6.53 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-3.63)[ip: (-9.53), ipnet: 199.48.128.0/22(-4.75), asn: 36236(-3.82), country: US(-0.05)]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; SIGNED_PGP(-2.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 19:46:27 -0000 --/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 28, 2020 at 07:42:04PM -0700, Enji Cooper wrote: >=20 > > On Mar 28, 2020, at 7:37 PM, Enji Cooper wrote: > >=20 > >>=20 > >> On Mar 27, 2020, at 8:22 PM, Brooks Davis > wrote: > >>=20 > >> On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote: > >>> Author: ngie > >>> Date: Sat Mar 28 01:08:20 2020 > >>> New Revision: 359385 > >>> URL: https://svnweb.freebsd.org/changeset/base/359385 > >>>=20 > >>> Log: > >>> Check in the generated copies of the manpages > >>>=20 > >>> These manpages were meant to be templated once per `configure` run. > >>>=20 > >>> Given that we're not bound by as many constants, e.g., `--prefix` is= n't > >>> generally changing for kyua in the base system, having to generate t= he > >>> manpages each build seems slightly less than optimal. > >>>=20 > >>> In the event that one's build environment doesn't define `$SH`, the = build > >>> will also fail until this change is introduced. > >>>=20 > >>> Instead of jumping through hoops dealing with shells or permissions,= let's > >>> just cut to the chase and check the generated copies into the source= base > >>> under usr.bin/kyua . > >>=20 > >> This was the wrong fix. Committing generated manpaged was > >> 100% the wrong solution and will make extra work in the > >> future. The correct fix is almost certainly the one attached to > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245086 . If someone > >> doesn't beat me to it I will revert you wrong and broken commit along > >> with the followups and commit the correct one (this certainly won't be > >> until at least tomorrow). > >=20 > > I???ll revert my changes. >=20 > Done in r359417. Thank you! -- Brooks --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJegPr+AAoJEKzQXbSebgfAcDoH/jHGMExVpniE2bbsITQR5MA3 FzFfcWJ/OPtEShcTNDhPiYePrcXXE+tcGP8bvcQKmzWRYw05qKeXKYn8MZZ/FNBc bPLF3zP8POpd6ph+N+0XTsLXn8lliw8pZ1UnlJ20rkFwKZWuEv67TwcZ9U1Ut9VV y2AyqpIC0OZOTY95DCc4/T6UzxWWMePuSJFliol4DUxO0fjLC5pAvvYi6Ep135fL YrPetjkofYm66iT3gvhvVSJ/9jM7y4u/ivEK8a1aMHoNZsbBEKi1IGv8l5bOfADz HTZp8v4dB6U41WbNy+38yZWsMffr046eNLQGZodQu9WvN7JvkZg2cS4c8zKMydg= =kV6m -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK--