Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Dec 2018 06:45:20 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 234408] games/oolite: Update to 1.88
Message-ID:  <bug-234408-7788-mTmqg1fYVy@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-234408-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-234408-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234408

lightside <lightside@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200519|0                           |1
        is obsolete|                            |

--- Comment #2 from lightside <lightside@gmx.com> ---
Created attachment 200520
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200520&action=
=3Dedit
Proposed patch (since 480741 revision)

According to GCC compiler documentation, the alternative name for "-O" is "=
-O1"
for compiler option:
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#Optimize-Options

Probably, possible to use "-O1" instead of "-O2", if needed. I just used so=
me
default value in ports for amd64 architecture, which returned by `make -C
/usr/ports -V CFLAGS` command.

The "-O" and "-O2" compiler options are used in /usr/src/share/mk/sys.mk fi=
le,
based on different conditions, for example:
https://github.com/freebsd/freebsd/blob/5c861640127b95aa6b29327a48da153695e=
84c10/share/mk/sys.mk#L164-L177

Also possible, that message in BROKEN_aarch64 variable is outdated and ther=
e is
no need for related changes for deps/mozilla/js/src/configure file, after
OBJC_CLANG_VERSION=3D60 in ports r480741.

As I understood, the "-O" compiler flag is used to build
deps/mozilla/js/src/shell/js.cpp file:
https://github.com/OoliteProject/spidermonkey-ff4/blob/ca2fb5423fab4d72a3dc=
5fec911ce20bda01f223/js/src/shell/js.cpp

So, I decided to remove related changes from the patch. I guess, someone ju=
st
need to check support for "-O" compiler option for aarch64 architecture,
otherwise possible to propose patch to change this value for
deps/mozilla/js/src/configure file.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234408-7788-mTmqg1fYVy>