Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Apr 2019 22:27:56 +0000 (UTC)
From:      Ian Lepore <ian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r346713 - head/sys/dev/gpio
Message-ID:  <201904252227.x3PMRuYc013462@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ian
Date: Thu Apr 25 22:27:56 2019
New Revision: 346713
URL: https://svnweb.freebsd.org/changeset/base/346713

Log:
  Fix typo: the 4th argument to GPIO_PIN_ACCESS_32 is the set of pins to
  change, not the variable used to return the original pin state.
  
  PR:		237378
  Reported by:	Mori Hiroki <yamori813@yahoo.co.jp>

Modified:
  head/sys/dev/gpio/gpioc.c

Modified: head/sys/dev/gpio/gpioc.c
==============================================================================
--- head/sys/dev/gpio/gpioc.c	Thu Apr 25 21:54:32 2019	(r346712)
+++ head/sys/dev/gpio/gpioc.c	Thu Apr 25 22:27:56 2019	(r346713)
@@ -192,7 +192,7 @@ gpioc_ioctl(struct cdev *cdev, u_long cmd, caddr_t arg
 		case GPIOACCESS32:
 			a32 = (struct gpio_access_32 *)arg;
 			res = GPIO_PIN_ACCESS_32(sc->sc_pdev, a32->first_pin,
-			    a32->clear_pins, a32->orig_pins, &a32->orig_pins);
+			    a32->clear_pins, a32->change_pins, &a32->orig_pins);
 			break;
 		case GPIOCONFIG32:
 			c32 = (struct gpio_config_32 *)arg;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904252227.x3PMRuYc013462>