From owner-freebsd-stable@freebsd.org Wed Jun 12 06:22:02 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5ED4315A8619 for ; Wed, 12 Jun 2019 06:22:02 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13::5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "eg.sd.rdtc.ru", Issuer "eg.sd.rdtc.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BE20E8F599 for ; Wed, 12 Jun 2019 06:22:00 +0000 (UTC) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: freebsd-stable@freebsd.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id x5C6LZdc071632 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 12 Jun 2019 13:21:35 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: fsck vs zvol To: "O'Connor, Daniel" References: <06546140-1B02-432D-8B7C-525AA1EA4FBA@dons.net.au> <12AF5B03-1CD2-4D40-B6B7-0E4A65BCBACD@dons.net.au> Cc: freebsd-stable From: Eugene Grosbein Message-ID: <2954d620-90c6-a453-a169-d0d3f1610da7@grosbein.net> Date: Wed, 12 Jun 2019 13:21:28 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <12AF5B03-1CD2-4D40-B6B7-0E4A65BCBACD@dons.net.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BE20E8F599 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-1.01 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.43)[-0.427,0]; MX_INVALID(0.50)[cached]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.93)[-0.935,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; R_SPF_PERMFAIL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.05)[-0.054,0]; IP_SCORE(0.00)[country: RU(0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:29072, ipnet:2a03:3100::/32, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jun 2019 06:22:02 -0000 12.06.2019 12:17, O'Connor, Daniel wrote: >> Please show your /etc/fstab line for this UFS-inside-ZVOL and your changes to rc.d/fsck. >> Your logs do not show that fsck is started so I presume some mistake in the /etc/fstab. >> Maybe you forgot that it needs non-zero sixth field. > > The fsck line is.. > /dev/zvol/zroot/samba4sysvol /var/db/samba4/sysvol ufs rw,acls 0 0 > > The diff is just.. > --- fsck.orig 2019-06-12 14:43:03.279407000 +0930 > +++ fsck 2019-06-12 14:42:51.094142000 +0930 > @@ -24,6 +24,10 @@ > # During fsck ignore SIGQUIT > trap : 3 > > + echo "Samba FS hack" > + fsck -y /dev/zvol/zroot/samba4sysvol > + err=$? > + > check_startmsgs && echo "Starting file system checks:" > if checkyesno background_fsck; then > fsck -F -p > > Oh I see for the passno field.. It must be non-zero it fsck won't check it at all! And you don't need to change /etc/rc.d/fsck script at all.