From owner-cvs-lib  Tue Sep 24 10:01:11 1996
Return-Path: owner-cvs-lib
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id KAA29846
          for cvs-lib-outgoing; Tue, 24 Sep 1996 10:01:11 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA26476;
          Tue, 24 Sep 1996 09:53:53 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id CAA07060; Wed, 25 Sep 1996 02:48:34 +1000
Date: Wed, 25 Sep 1996 02:48:34 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199609241648.CAA07060@godzilla.zeta.org.au>
To: ache@nagual.ru, bde@freefall.freebsd.org
Subject: Re: cvs commit:  src/games/fortune/fortune fortune.c src/lib/libss help.c src/sys/i386/boot/biosboot sys.c src/usr.bin/msgs msgs.c s
Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org,
        cvs-games@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org,
        cvs-lib@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org,
        cvs-sys@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org,
        cvs-usrsbin@freefall.freebsd.org
Sender: owner-cvs-lib@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>What do you think about adding some #warning in <sys/dir.h> like
>for <malloc.h> case?

Already done, but not committed.

What about removing DIRSIZ() completely?  This would leave <sys/dir.h> as
just defining `direct' as `dirent'.  DIRSIZ() is mainly used for building
`struct dirent's and wasn't used in /usr/src except in the kernel.

I sent mail to freebsd-fs about related cruft in the kernel, but got
no reply.  cd9660 and devfs use DIRSIZ() from <sys/dir.h>.  ufs uses
its own DIRSIZ() which is really for the on-disk entries but happens to
work for readdir() on all supported systems (I think it would fail if
64-bit alignment is required).  ext2fs uses too much ufs directory stuff,
but not DIRSIZ().  nfs uses ufs's DIRBLKSIZ, which is different from
the application DIRBLKSIZ defined in <dirent.h>.  <sys/dir.h> attempts
to include <dirent.h>, but actually includes <sys/dirent.h> because of
the crufty -I$S/sys in the kernel makefiles.

Bruce