Date: Fri, 28 Jan 2000 18:33:29 +0100 (CET) From: Soren Schmidt <sos@freebsd.dk> To: rock@dead-end.net (D. Rock) Cc: current@FreeBSD.ORG Subject: Re: ata: panic with new sysctl variable Message-ID: <200001281733.SAA19957@freebsd.dk> In-Reply-To: <3891BF08.35C20143@dead-end.net> from "D. Rock" at "Jan 28, 2000 05:08:40 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
It seems D. Rock wrote: > Hi, > > just noticed the new sysctl variable for ata. I just wanted to > use the new way for disabling DMA on my disk (has some strange > problems, even under windows). > > Previously I just commented out the ata_dmainit() lines in > ata_disk.c, now I wanted to set it with sysctl: > > sysctl -w hw.atamodes="pio,dma,dma,dma" > > but this paniced my machine. > > I later discovered that there is no sanity check during setting > the new modes: The machine in question didn't have a secondary > IDE controller, but the variables were set without a range check. > > My solution was simple. Just use > sysctl -w hw.atamodes="pio,dma" > > but I think, the ata driver should range check the settings. It does but not for the first two devices as the are kindof magic in some sense. I'll commit the fix asap.. -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001281733.SAA19957>