From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 1 01:00:23 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE4A516A4CE for ; Fri, 1 Apr 2005 01:00:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DCFD43D48 for ; Fri, 1 Apr 2005 01:00:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3110Na0086196 for ; Fri, 1 Apr 2005 01:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3110NrJ086195; Fri, 1 Apr 2005 01:00:23 GMT (envelope-from gnats) Date: Fri, 1 Apr 2005 01:00:23 GMT Message-Id: <200504010100.j3110NrJ086195@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: =?ISO-8859-1?Q?Se=E1n_C=2E_Farley?= Subject: Re: ports/79259: [PATCH] net/samba: WITHOUT_{ADS,CUPS} fix X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: =?ISO-8859-1?Q?Se=E1n_C=2E_Farley?= List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2005 01:00:23 -0000 The following reply was made to PR ports/79259; it has been noted by GNATS. From: =?ISO-8859-1?Q?Se=E1n_C=2E_Farley?= To: "Timur I. Bakeyev" Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: ports/79259: [PATCH] net/samba: WITHOUT_{ADS,CUPS} fix Date: Thu, 31 Mar 2005 18:59:21 -0600 (CST) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1240324963-1112317161=:50115 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 31 Mar 2005, Timur I. Bakeyev wrote: > Hi Sean! > > The patch itself looks ok, but can you explain, why do you need to > reverse the meaning of the knobs? I reversed the knobs to have it default to CUPS (current behavior) but accept the WITHOUT_CUPS flag to be able to override it. Defining WITH_CUPS is a noop since it was the default, therefore, it needs to look for WITHOUT_CUPS to be able to turn it off. The situation with WITHOUT_ADS is similar. > Are there any specific cases when current behavior doesn't give proper > results? For example, the following will still require CUPS: cd /usr/ports/net/samba3 make rmconfig make -DWITHOUT_CUPS -DBATCH I noticed this with a tool I wrote (pm.pl on http://www.farley.org/?page=3Dsoftware) similar to portupgrade, which will probably have the same problem. Se=E1n --=20 sean-freebsd@farley.org --0-1240324963-1112317161=:50115--