From owner-svn-src-all@freebsd.org Wed Aug 10 18:41:13 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDF03BB587B; Wed, 10 Aug 2016 18:41:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D639B1D39; Wed, 10 Aug 2016 18:41:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u7AIf27M009541 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 10 Aug 2016 21:41:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u7AIf27M009541 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u7AIf2xo009540; Wed, 10 Aug 2016 21:41:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 10 Aug 2016 21:41:02 +0300 From: Konstantin Belousov To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303934 - head/usr.bin/truss Message-ID: <20160810184102.GW83214@kib.kiev.ua> References: <201608101819.u7AIJHIh079589@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201608101819.u7AIJHIh079589@repo.freebsd.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 18:41:13 -0000 On Wed, Aug 10, 2016 at 06:19:17PM +0000, Bryan Drewery wrote: > Author: bdrewery > Date: Wed Aug 10 18:19:17 2016 > New Revision: 303934 > URL: https://svnweb.freebsd.org/changeset/base/303934 > > Log: > Support rmdir(2). > > MFC after: 3 days > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/usr.bin/truss/syscalls.c > > Modified: head/usr.bin/truss/syscalls.c > ============================================================================== > --- head/usr.bin/truss/syscalls.c Wed Aug 10 18:19:14 2016 (r303933) > +++ head/usr.bin/truss/syscalls.c Wed Aug 10 18:19:17 2016 (r303934) > @@ -279,6 +279,8 @@ static struct syscall decoded_syscalls[] > .args = { { Name, 0 }, { Name, 1 } } }, > { .name = "renameat", .ret_type = 1, .nargs = 4, > .args = { { Atfd, 0 }, { Name, 1 }, { Atfd, 2 }, { Name, 3 } } }, > + { .name = "rmdir", .ret_type = 1, .nargs = 2, > + .args = { { Name, 0 }, { Octal, 1 } } }, I do not quite follow this. The table format is that nargs is the number of arguments to the syscall, and args describe each syscall' argument, are my assumptions right ? If yes, what is the second rmdir(2) argument for ? > { .name = "rfork", .ret_type = 1, .nargs = 1, > .args = { { Rforkflags, 0 } } }, > { .name = "select", .ret_type = 1, .nargs = 5,