From owner-svn-ports-all@FreeBSD.ORG  Mon Aug 25 13:59:35 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 135F0995;
 Mon, 25 Aug 2014 13:59:35 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7F2113E6E;
 Mon, 25 Aug 2014 13:59:34 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 5354443BF4;
 Mon, 25 Aug 2014 08:59:14 -0500 (CDT)
Message-ID: <53FB4122.3060402@marino.st>
Date: Mon, 25 Aug 2014 15:58:58 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: marino@freebsd.org
Subject: Re: svn commit: r365735 - in head/games: . prboom-plus
References: <201408231404.s7NE4Ds7036892@svn.freebsd.org>
 <20140825093243.GC66191@FreeBSD.org>
 <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org> <53FB3FB3.90508@marino.st>
 <9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7@adamw.org>
In-Reply-To: <9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7@adamw.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
 Adam Weinberger <adamw@FreeBSD.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2014 13:59:35 -0000

On 8/25/2014 15:55, Adam Weinberger wrote:
> On 25 Aug, 2014, at 9:52, John Marino <freebsd.contact@marino.st> wrote:
> 
>> On 8/25/2014 15:43, Adam Weinberger wrote:
>>> On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe@FreeBSD.org>
>>> wrote:
>>>> COMMENT line is wrong. :)
>>>
>>> Because it starts with an article? I’d posit that that article
>>> improves readability of this particular COMMENT.
>>
>> Yes, because it starts with an article.   We've been instructed to
>> remove them unconditionally.
>> Hundreds of ports have comments equivalent to "Fork of the doom game
>> engine prboom", so it's not special in any way.
>>
>> Unfortunately portlint doesn't check for this.  I'd add this to the
>> current catch-all portlint rule PR.
> 
> Guys, if it’s not right, please just fix it!
> 

It's more than that -- Let's say you really think starting with "A " is
essential not matter what the rule is, then it makes sense to discuss it
to prevent it in the future.  It's not being lazy or critical, it's
educating.  At least I believe that is the intent.

John