From owner-svn-src-all@FreeBSD.ORG Thu Jan 29 00:39:06 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C72B19A7 for ; Thu, 29 Jan 2015 00:39:06 +0000 (UTC) Received: from nm50.bullet.mail.bf1.yahoo.com (nm50.bullet.mail.bf1.yahoo.com [216.109.114.67]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B85BBEC for ; Thu, 29 Jan 2015 00:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1422491937; bh=R5KSG9xDLnJrE33rzFBhUsI8nTXdCedJlZm++w0LEnU=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=SjwBr12hHDN1uzUWK4+edYLmQrdC8zb4gyL+Sqz7iD2RMabtUkQvplxX1vBHwG9ONjoVarzkLmkiNM2aq7aH00OeI7LUYuU9SIeFbAzjgo3N9vYu451owGi8dgh1yThf0sDDmCZXEpx+9/48I2nLOMWgFGzLbDaxhd+IsNSinfTW1D+5yrpL2rGBKh80cCK1unmjotIpo/zNoWg5DnVZVH8Etq5IejfVhWsar7/xOxFCZEqQIIAWtMZtU5sbwA9wFHDeRA3CoPLPMPoVAuoE9TXS7kgaLKHw9a1B38DsBGucSzw1bRkoUp9SMzGM1hbv7mL3DQTIrKNiBH1np6zWeA== Received: from [98.139.215.141] by nm50.bullet.mail.bf1.yahoo.com with NNFMP; 29 Jan 2015 00:38:57 -0000 Received: from [98.139.213.10] by tm12.bullet.mail.bf1.yahoo.com with NNFMP; 29 Jan 2015 00:38:57 -0000 Received: from [127.0.0.1] by smtp110.mail.bf1.yahoo.com with NNFMP; 29 Jan 2015 00:38:57 -0000 X-Yahoo-Newman-Id: 858615.55222.bm@smtp110.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: RwjJ_WMVM1m2dC.d2B_AO6xz5PKMrzeB5D7M3GphpwZFi3s 8DAdFSJcep.BGwQJttj1AqaibTmuEjJxShujf.ullRcL3GqdTx9mjHEEa_i7 CvQifym3.PiLgNY.tXWgmA.Thx.WqzwCB8wEgSkrwN55pv.fCocST4aiFubH yrNfeNsI8WbbUy03OqzP548D.W8XDV8CvOyOgpZ_kkVDDGSOlZ0MSd2DMYiH ono_Bnr1SS7RQACv1M8xjCqnUDFdAlOh8PCoboitzPoVAf5KSEk7EmXWDzW. oFTIHRCRQ2NYzDNNiUkbeWqmTOa7IhVwL1GDIR2VbNLva6gjJcLnXDfzwm0p fKnZm01y3zndy8gFLRZmKwf6pm251.NE2WwqUmDMeTgFK2UbmslAHEEH067W 14XJtX3FoDHjM4xM7rsOG1l4tE9sWIltXmkihAHtP4mqKoYIKoRKKH2Oby2f rfzro_XUdD62Dk8iD8ydBAah6fPFaEAlH2guyrQUrih.8SYY4o8Tubt23k7H ePTYYOVh0h.Pzl9Z3_GntfI6c9Gi.lMHW6w8SPi3H_wrd8EtkPG4tArHk.Ry QWEefHkl3RHiz2Nhm5_WFq_qWzAlPsib2Z5xiK9po6dBeJWk6hvIAGwkIZrt HbNmvzJGqLvzaz1EcP4MxXQujNUMYE7BjbWUR7qoUBD6kX_FvBuOUio1b1__ H4cDuMm7rEuxE5klk2w-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <54C98137.60507@FreeBSD.org> Date: Wed, 28 Jan 2015 19:39:19 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dimitry Andric , Roman Divacky Subject: Re: svn commit: r277841 - head/contrib/amd/hlfsd References: <201501281819.t0SIJQG4073269@svn.freebsd.org> <20150128190422.GA58164@vlakno.cz> <874F65B6-0C1A-4230-B277-119C31BA31D7@FreeBSD.org> In-Reply-To: <874F65B6-0C1A-4230-B277-119C31BA31D7@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 00:39:07 -0000 On 01/28/15 14:25, Dimitry Andric wrote: > On 28 Jan 2015, at 20:04, Roman Divacky wrote: >> On Wed, Jan 28, 2015 at 06:19:26PM +0000, Dimitry Andric wrote: >>> Author: dim >>> Date: Wed Jan 28 18:19:25 2015 >>> New Revision: 277841 >>> URL: https://svnweb.freebsd.org/changeset/base/277841 >>> >>> Log: >>> Fix the following clang 3.6.0 warning in contrib/amd/hlfsd/homedir.c: >>> >>> contrib/amd/hlfsd/homedir.c:497:8: error: address of array 'buf' will >>> always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] >>> if (!buf || buf[0] == '\0') >>> ~^~~ >>> >>> In the affected function, 'buf' is declared as an array of char, so it >>> can never be null. Remove the unecessary check. > ... >> Given that this is a contributed code - have you sent the fix >> upstream? Also, upstream seems to have newer versions of this... > Apparently upstream fixed this about six years ago: > > http://git.fsl.cs.sunysb.edu/?p=am-utils-6.2.git;a=commitdiff;h=e6301006ef97d31745f9ffbb17c58cb39d18c6aa#patch9 > > The last real import for am-utils was about 7 year ago. Maybe it's time > for an update, if it is still actively used. > > -Dimitry > I have no idea if this should be updated (it's probably meant to be replaced by autofs nowadays) but the patches should be merged through the vendor area so I flattened the distdir and brought I change I had done there. Regards, Pedro.